Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle gracefully when an invalid devfile is found in a git repository #20738

Closed
Tracked by #21653
l0rd opened this issue Nov 5, 2021 · 4 comments · Fixed by eclipse-che/che-dashboard#643
Closed
Tracked by #21653

Handle gracefully when an invalid devfile is found in a git repository #20738

l0rd opened this issue Nov 5, 2021 · 4 comments · Fixed by eclipse-che/che-dashboard#643
Assignees
@olexii4
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@l0rd
Copy link
Contributor

l0rd commented Nov 5, 2021 •
edited
Loading

Is your enhancement related to a problem? Please describe

Currently Che starts successfully workspaces from a Git repository where there are no devfiles: the default component and editor will be used. When a workspace has a devfile that's invalid instead, there is no way for a user to start it using the default component (to fix the devfile for example).

Describe the solution you'd like

When Che finds a devfile in a git repository but that's an invalid devfile, we should warn the user and prompt him if the workspace should start anyway (ignoring the existing devfile) or if he wants to cancel the workspace startup.

warning-invalid-devfile

This is related to #20616.

Release Notes Text

Workspace creation doesn't fail anymore if the developer provides an invalid Devfile (or if an invalid Devfile is found in the git repository provided by the developer). Instead a warning is shown asking wether the workspace should be started anyway with a default Devfile. This is particularly useful when a developer is editing and testing a Devfile.
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Nov 5, 2021
@l0rd l0rd changed the title Handle gracefully Devfile with a versions that is not supported Handle gracefully Devfiles with a versions that is not supported by Che Nov 5, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 5, 2021
@l0rd l0rd added area/dashboard severity/P1 Has a major impact to usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 5, 2021
@l0rd l0rd mentioned this issue Nov 5, 2021
Closed
1 task
@l0rd l0rd mentioned this issue Jan 24, 2022
Closed
4 tasks
@l0rd l0rd mentioned this issue Mar 2, 2022
Closed
9 tasks
@che-bot
Copy link
Contributor

che-bot commented May 4, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2022
@che-bot che-bot closed this as completed May 11, 2022
@l0rd l0rd reopened this May 13, 2022
@l0rd l0rd removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2022
@l0rd l0rd changed the title Handle gracefully Devfiles with a versions that is not supported by Che Handle gracefully invalid devfiles Jul 18, 2022
@l0rd l0rd changed the title Handle gracefully invalid devfiles Handle gracefully when an invalid devfile is found in a git repository Jul 18, 2022
@ibuziuk ibuziuk mentioned this issue Jul 18, 2022
Closed
51 tasks
@l0rd
Copy link
Contributor Author

l0rd commented Jul 22, 2022

I have updated the wireframe and the description.

@olexii4 olexii4 self-assigned this Jul 25, 2022
@l0rd l0rd mentioned this issue Aug 3, 2022
Closed
@l0rd
Copy link
Contributor Author

l0rd commented Aug 4, 2022

I have updated the warning text after some a @RickJWagner comment on #21606

@ibuziuk ibuziuk mentioned this issue Aug 9, 2022
Closed
67 tasks
@ibuziuk ibuziuk mentioned this issue Aug 30, 2022
Closed
82 tasks
@ibuziuk ibuziuk mentioned this issue Oct 4, 2022
Closed
59 tasks
@olexii4 olexii4 mentioned this issue Oct 5, 2022
Merged
@ibuziuk ibuziuk mentioned this issue Oct 11, 2022
Closed
67 tasks
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Oct 27, 2022
@l0rd l0rd mentioned this issue Oct 31, 2022
Closed
@ibuziuk ibuziuk mentioned this issue Nov 29, 2022
Closed
@AObuchow AObuchow mentioned this issue Dec 8, 2022
Closed
@max-cx
Copy link

max-cx commented Dec 15, 2022

Sync'd with Red Hat JIRA https://issues.redhat.com/browse/CRW-3638

@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olexii4 olexii4

Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle gracefully when an invalid devfile is found in a git repository eclipse-che/che-dashboard
5 participants
@l0rd @ibuziuk @olexii4 @che-bot @max-cx