Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display workspace runningLimit in warning message #620

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Sep 2, 2022

Signed-off-by: David Kwon [email protected]

What does this PR do?

Prints the current workspaces running limit spec.devWorkspace.runningLimit when

image

image

What issues does this PR fix or reference?

Is it tested? How?

  1. Follow these steps to run this PR locally. (or, use the docker image built for this PR)
    By default, Eclipse Che's workspace runningLimit is 1. In the CheCluster spec, the value comes from spec.components.devWorkspace.runningLimit.

  2. Start a workspace from the dashboard, and immediately start another one. The warning message should state that the running workspaces limit is 1.

  3. Increase spec.components.devWorkspace.runningLimit to 2.

  4. From the dashboard, start two workspaces. Start a third one to see the warning message stating that the workspaces limit is 2.

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-620

@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2022

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path dea11fd link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants