-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display workspace runningLimit in warning message #620
Conversation
Signed-off-by: David Kwon <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-620 |
@dkwon17: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: David Kwon [email protected]
What does this PR do?
Prints the current workspaces running limit
spec.devWorkspace.runningLimit
whenWhat issues does this PR fix or reference?
Is it tested? How?
Follow these steps to run this PR locally. (or, use the docker image built for this PR)
By default, Eclipse Che's workspace runningLimit is 1. In the CheCluster spec, the value comes from
spec.components.devWorkspace.runningLimit
.Start a workspace from the dashboard, and immediately start another one. The warning message should state that the running workspaces limit is 1.
Increase
spec.components.devWorkspace.runningLimit
to 2.From the dashboard, start two workspaces. Start a third one to see the warning message stating that the workspaces limit is 2.
Release Notes
Docs PR