Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display current runningLimit on the Dashboard when workspaces runningLimit reached #21669

Closed
Tracked by #21653
dkwon17 opened this issue Aug 29, 2022 · 2 comments
Closed
Tracked by #21653

Display current runningLimit on the Dashboard when workspaces runningLimit reached #21669

dkwon17 opened this issue Aug 29, 2022 · 2 comments
Assignees
@dkwon17
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Aug 29, 2022

Is your enhancement related to a problem? Please describe

By default, the workspace runningLimit is 1. When there is already a running workspace, and if another workspace has been started via the dashboard, this error message appears:
image

Describe the solution you'd like

It would be great if the error message also specified what the workspace runningLimit is.

Instead of You are not allowed to start more workspaces, something like:

  • You can only run 1 workspace at a time or
  • Only 1 workspace can be running at a time

could be more helpful

Describe alternatives you've considered

No response

Additional context

No response
@dkwon17 dkwon17 added the kind/enhancement A feature request - must adhere to the feature request template. label Aug 29, 2022
@dkwon17 dkwon17 mentioned this issue Aug 29, 2022
Closed
82 tasks
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 29, 2022
@dkwon17 dkwon17 added severity/P2 Has a minor but important impact to the usage or development of the system. area/dashboard labels Aug 29, 2022
@dkwon17
Copy link
Contributor Author

dkwon17 commented Aug 29, 2022

This seems quite straight-forward to implement, probably only need to update a string here:
https://github.com/eclipse-che/che-dashboard/blob/6f0c322c9ba0baf2a13c8e93a64e1b14b64df91d/packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts#L298

@dkwon17 dkwon17 mentioned this issue Aug 30, 2022
Closed
@l0rd l0rd removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 30, 2022
@ibuziuk
Copy link
Member

ibuziuk commented Sep 16, 2022

@dkwon17 looks like this issue has been fixed with eclipse-che/che-dashboard#620
can we close it now?

@dkwon17 dkwon17 closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkwon17 dkwon17

Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@l0rd @ibuziuk @che-bot @dkwon17