Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve errors in michelson encoder #2539

Closed
wants to merge 9 commits into from

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented Jun 21, 2023

closes #1995

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

ac10n and others added 9 commits May 24, 2023 13:43
* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts
* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts
* Update nairobi in other files

* undo changes to versioned docs

* chore: rename PtNairob to PtNairobi
* feat: updated GasLimit for reveal in Nairobi

fix #2447

* fix: change mumbai tests to also run for later protocols

* chore: fix failing unit tests

* Fix failoing integration test

* chore: rename PtNairob to PtNairobi

* chore: apply changes as suggested by davis

* chore: remove the unused logic

* chore: fix values for the consumedMilligas in failing tests

* fix unit tests after changes to reveal gasLimit

* chore: revert gas limit for reveal to 2200
* fixed contract call estimate prep to check for reveal (#2502)

* fixed contract call estimate prep to check for reveal

* changed logic slightly

* added keygen diagram to integration test readme (#2504)

* added keygen diagram

* text improvement

* typo fix

* Upgrade netlify-cli to fix the android dependency problem (#2496)

* Re-create package-lock.json in root and website to trigger the problem

* Upgrade netlify-cli

* update most dependencies in website

* Add EventSchema to ContractAbstraction

* Remove duplicate events

* fix typo

* test: added integration test for events in ContractAbstraction

* docs: add documentation for eventSchema

---------

Co-authored-by: Davis Sawali <[email protected]>
Co-authored-by: Michael Kernaghan <[email protected]>
* removed mumbai references in v17

* add block call for mumbai to get protocol constants

* remove extraneous line

* updated assertion values

* updated assertion

* fix test protocol constants

* addressed pr comment and added proto15 tests
* Configure Nairobinet for Integration Tests (#2492)

* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts

* updated types for sc_rollup_cement in N

* updated unit test for updated types

---------

Co-authored-by: AlirezaHaghshenas <[email protected]>
@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit dd588fe
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/649325774d22e00008052906
😎 Deploy Preview https://deploy-preview-2539--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ac10n ac10n closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error in the Michelson-Encoder package
2 participants