Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2447 update gas limit for reveal in nairobi #2494

Merged
merged 10 commits into from
Jun 2, 2023

Conversation

ac10n
Copy link
Contributor

@ac10n ac10n commented May 24, 2023

Closes #2447
Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@ac10n ac10n force-pushed the 2447-update-gas-limit-for-reveal-in-nairobi branch from f99c06d to 3eca6c4 Compare May 24, 2023 20:58
@ac10n ac10n mentioned this pull request May 24, 2023
9 tasks
@github-actions
Copy link

github-actions bot commented May 24, 2023

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@ac10n ac10n force-pushed the 2447-update-gas-limit-for-reveal-in-nairobi branch 2 times, most recently from 7c83b75 to 5a5b22f Compare May 29, 2023 16:28
@ac10n ac10n changed the base branch from 17.0.0 to master May 29, 2023 21:42
@ac10n ac10n changed the base branch from master to 17.0.0 May 29, 2023 21:42
@ac10n ac10n force-pushed the 2447-update-gas-limit-for-reveal-in-nairobi branch from 5a5b22f to 3f6b023 Compare May 30, 2023 17:08
@ac10n ac10n marked this pull request as ready for review May 31, 2023 17:22
@ac10n ac10n requested a review from dsawali May 31, 2023 19:15
integration-tests/rpc-get-protocol-constants.spec.ts Outdated Show resolved Hide resolved
packages/taquito/src/constants.ts Outdated Show resolved Hide resolved
@ac10n ac10n force-pushed the 2447-update-gas-limit-for-reveal-in-nairobi branch from fade4fc to 8ce86f1 Compare June 1, 2023 20:40
@ac10n ac10n force-pushed the 2447-update-gas-limit-for-reveal-in-nairobi branch from 27db560 to 9dd24ff Compare June 1, 2023 21:31
@ac10n ac10n requested a review from dsawali June 2, 2023 00:10
@ac10n ac10n merged commit cae7fed into 17.0.0 Jun 2, 2023
@ac10n ac10n deleted the 2447-update-gas-limit-for-reveal-in-nairobi branch June 2, 2023 00:22
dsawali added a commit that referenced this pull request Jun 13, 2023
* Configure Nairobinet for Integration Tests (#2492)

* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts

* Configure Nairobinet for Integration Tests (#2492)

* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts

* Update nairobi in other files (#2506)

* Update nairobi in other files

* undo changes to versioned docs

* chore: rename PtNairob to PtNairobi

* 2447 update gas limit for reveal in nairobi (#2494)

* feat: updated GasLimit for reveal in Nairobi

fix #2447

* fix: change mumbai tests to also run for later protocols

* chore: fix failing unit tests

* Fix failoing integration test

* chore: rename PtNairob to PtNairobi

* chore: apply changes as suggested by davis

* chore: remove the unused logic

* chore: fix values for the consumedMilligas in failing tests

* fix unit tests after changes to reveal gasLimit

* chore: revert gas limit for reveal to 2200

* Add EventSchema to ContractAbstraction (#2485)

* fixed contract call estimate prep to check for reveal (#2502)

* fixed contract call estimate prep to check for reveal

* changed logic slightly

* added keygen diagram to integration test readme (#2504)

* added keygen diagram

* text improvement

* typo fix

* Upgrade netlify-cli to fix the android dependency problem (#2496)

* Re-create package-lock.json in root and website to trigger the problem

* Upgrade netlify-cli

* update most dependencies in website

* Add EventSchema to ContractAbstraction

* Remove duplicate events

* fix typo

* test: added integration test for events in ContractAbstraction

* docs: add documentation for eventSchema

---------

Co-authored-by: Davis Sawali <[email protected]>
Co-authored-by: Michael Kernaghan <[email protected]>

* removed mumbai references in v17 (#2511)

* removed mumbai references in v17

* add block call for mumbai to get protocol constants

* remove extraneous line

* updated assertion values

* updated assertion

* fix test protocol constants

* addressed pr comment and added proto15 tests

* updated types for sc_rollup_cement in N (#2497)

* Configure Nairobinet for Integration Tests (#2492)

* Configure Nairobinet

* More Nairobinet configs

* Originated known contracts

* updated types for sc_rollup_cement in N

* updated unit test for updated types

---------

Co-authored-by: AlirezaHaghshenas <[email protected]>

* Both Mumbai and Nairobi integration test configurations should coexist

* 1996 rpc 2 (#2522)

* added validation for transferred amounts and updated readme

* update flextesa image version

* update sequence of test

* chore(releng) bump version to 17.0.0-beta-RC.0

* chore: satisfy lerna

* chore(releng) bump version to 17.0.0

---------

Co-authored-by: AlirezaHaghshenas <[email protected]>
Co-authored-by: Michael Kernaghan <[email protected]>
Co-authored-by: Daniele Lisi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants