Add Sentry cron monitoring #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongmassey
force-pushed
the
Jongmassey/cron-sentry
branch
4 times, most recently
from
b986cbc to
90c4a83
Compare
Jongmassey
force-pushed
the
Jongmassey/cron-sentry
branch
3 times, most recently
from
d804720 to
9c67b00
Compare
Based on configuration example from Sentry docs. Timezone and schedule match current config on dokku3 Previous runs of the cron job seem to take <10mins in total. Therefore 10 minutes runtime for each individual task should be plenty. The first task in the list is expected to start shortly after midnight, but the later ones might not start until nearly 10 past. Therefore 30 mins chosen to give a bit of leeway on the checkin time.
This method is the entry point for the cron job, which is what we want to be monitoring Running the tasks in isolation (e.g. for testing) would not be monitored
Jongmassey
force-pushed
the
Jongmassey/cron-sentry
branch
from
9c67b00 to
a68aa10
Compare
lucyb
reviewed
Jun 26, 2024
Jongmassey
force-pushed
the
Jongmassey/cron-sentry
branch
from
c0f0de4 to
57f6304
Compare
|
@lucyb I've refactored things in 02b85a3 . My thinking is that the SDK is initialised once per execution of the cron job, then for each task, a new |
lucyb
reviewed
Jun 27, 2024
Jongmassey
force-pushed
the
Jongmassey/cron-sentry
branch
from
02b85a3 to
e1394f4
Compare
lucyb
approved these changes
Jul 1, 2024
|
Thanks, Lucy. Based on my testing - the Sentry issues raised by this cron monitoring do not appear in #sentry-events on Slack. It appears that the alert configuration requires both an Event and a corresponding Issue to be triggered. We may need to change this configuration for these to appear in the slack channel. I'll create a new issue for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sentry cron monitoring to metrics so we can check it's running as it should be.
Fixes #105