Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all Client methods to async fn #213

Merged
merged 2 commits into from
Aug 16, 2020
Merged

Change all Client methods to async fn #213

merged 2 commits into from
Aug 16, 2020

Commits on Aug 16, 2020

  1. Change remaining Client notification methods to async fn 

    This not only guarantees a correct order of operations, but it
eliminates the very last internal call to `tokio::spawn()` in the
project. The only thing currently tying us to `tokio` specifically is
the `AsyncRead`/`AsyncWrite` traits.
    @ebkalderon
    ebkalderon committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    2296412 View commit details
    Browse the repository at this point in the history

  2. Update minimum supported Rust version to 1.41.0 

    This version includes a critical fix for `format!()` calls in async fn:

rust-lang/rust#64856
    @ebkalderon
    ebkalderon committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    af4bba5 View commit details
    Browse the repository at this point in the history