Change all Client methods to async fn #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This not only guarantees a correct order of operations, but it eliminates the very last internal call to `tokio::spawn()` in the project. The only thing currently tying us to `tokio` specifically is the `AsyncRead`/`AsyncWrite` traits.
This version includes a critical fix for `format!()` calls in async fn: rust-lang/rust#64856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Clientnotification methods toasync fn.With this PR, we have eliminated all uses of
tokio::spawnintower-lsp! 🎉 The only things currently tying us totokioat the moment are theAsyncReadandAsyncWritetraits. The Rust ecosystem is currently split down the middle between thetokioandfutures/async-stdversions of these traits, unfortunately, although efforts exist to stabilize them instd.Closes #180.