Fix graphene_box_get_center() #166

ebassi · 2019-08-08T10:06:12Z

Fixes #165

Proposed changes:

Fix various box methods to handle empty and infinite boxes
Fix graphene_box_get_center() to take into account the box.min point
Fix graphene_box_get_bounding_sphere() to use the box center instead of open coding it

Test suite changes:

Add expectations to the graphene_box_get_center() specification that check the behaviour of the function when box.min is not centered in (0, 0, 0)

We cannot rely on a consistent behaviour with infinities across different platforms, architectures, toolchains, and SIMD implementations. This means we need to check if a box's minimum and maximum vertices contain infinities before comparing the vertices.

Before we go into SIMD operations, we need to check for infinities, given that we might end up in an empty or infinite box.

We're subtracting the minimum and maximum coordinates, but that only works if the minimum point is centered in (0, 0, 0).

Instead of open-coding it, we should reuse the existing Box API, so we avoid duplicating bugs. Fixes: #165

Add more expectations on the behaviour of get_center(), especially when the minimum point of the box is not centered in (0, 0, 0).

ebassi added 5 commits August 8, 2019 14:14

box: Handle empty and infinite boxes a bit better

1f4847d

Before we go into SIMD operations, we need to check for infinities, given that we might end up in an empty or infinite box.

box: Fix get_center()

a30a446

We're subtracting the minimum and maximum coordinates, but that only works if the minimum point is centered in (0, 0, 0).

box: Reimplement get_bounding_sphere()

1ecc632

Instead of open-coding it, we should reuse the existing Box API, so we avoid duplicating bugs. Fixes: #165

tests/box: Check get_center()'s specification

a80f1f3

Add more expectations on the behaviour of get_center(), especially when the minimum point of the box is not centered in (0, 0, 0).

ebassi force-pushed the issue-165 branch from cf831d7 to a80f1f3 Compare August 8, 2019 13:18

ebassi merged commit f869b01 into master Aug 8, 2019

ebassi deleted the issue-165 branch August 8, 2019 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix graphene_box_get_center() #166

Fix graphene_box_get_center() #166

ebassi commented Aug 8, 2019 •

edited

Loading

Fix graphene_box_get_center() #166

Fix graphene_box_get_center() #166

Conversation

ebassi commented Aug 8, 2019 • edited Loading

ebassi commented Aug 8, 2019 •

edited

Loading