Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphene_box_get_bounding_sphere is incorrect #165

Closed
alexlarsson opened this issue Aug 8, 2019 · 0 comments · Fixed by #166
Closed

graphene_box_get_bounding_sphere is incorrect #165

alexlarsson opened this issue Aug 8, 2019 · 0 comments · Fixed by #166

Comments

@alexlarsson
Copy link
Contributor

It calculates the center as box_size * 0.5, but that always puts the box at the origin. It need to add box->min to center too.
ebassi added a commit that referenced this issue Aug 8, 2019
@ebassi
box: Reimplement get_bounding_sphere()
21603f1 
Instead of open-coding it, we should reuse the existing Box API, so we
avoid duplicating bugs.

Fixes: #165
@ebassi ebassi mentioned this issue Aug 8, 2019
Merged
ebassi added a commit that referenced this issue Aug 8, 2019
@ebassi
box: Reimplement get_bounding_sphere()
1ecc632 
Instead of open-coding it, we should reuse the existing Box API, so we
avoid duplicating bugs.

Fixes: #165
ebassi added a commit that referenced this issue Aug 8, 2019
@ebassi
box: Reimplement get_bounding_sphere()
26e0728 
Instead of open-coding it, we should reuse the existing Box API, so we
avoid duplicating bugs.

Fixes: #165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix graphene_box_get_center() ebassi/graphene
1 participant
@alexlarsson