allow usingamend/try-amend multiple times in an easystack file entry

[Crivella]

Related to:

• Can't use multiple --try-amend statements in Easystack entry #4643

This change checks if the option in the easystack belongs to a list of options that allows to be defined multiple times (could be defined in a more generic location) and instead of setting it's value as a list, will set it multiple times to the cli arguments.

Possible breaking change:

• Any currently existing easystack that makes use of a pattern like

    options:
      - try-amend:
        - opt=1
        - 2
        - 3
  

  in order to set --try-amend=opt=1,2,3 would not work anymore

[ocaisa]

LGTM but maybe @boegel wants to take a look as there is a (very unlikely to be used) breaking change in here (as mentioned in #4667 (comment))

[cgross95]

Thank you for working on this! I just tested and can verify that it works exactly as desired for our use case. If this does get merged in as is, I wrote up a documentation PR (that I am happy to edit as desired):

• Document how to make multiple calls with the same argument in an easystack file easybuild-docs#281

[boegel]

Can we also cover this with an enhanced test?

[Crivella]

I think that is already covered with

easybuild-framework/test/framework/options.py

Line 7239 in 3d29b0a

'from-pr': [1234, 2345],

[Crivella]

But i can add a separate test if needed

[boegel]

LGTM but maybe @boegel wants to take a look as there is a (very unlikely to be used) breaking change in here (as mentioned in #4667 (comment))

It's OK I think, especially since easystack files are (still) an experimental feature currently...

That said, it's high time we remove the experimental tag for easystack files, definitely for EasyBuild 5.0...

[bartoldeman]

@boegel does this still need work or can it be merged now?

[boegel]

lgtm