Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark easystack support as being mature, since it's no longer experimental #4673

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 8, 2024

No description provided.

@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Oct 8, 2024
@boegel boegel added this to the 5.0 milestone Oct 8, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ocaisa
Copy link
Member

ocaisa commented Oct 10, 2024

Can we hold off merging this until this PR is merged?

@boegel
Copy link
Member Author

boegel commented Nov 6, 2024

I really want to mark easystack support as non-experimental in EasyBuild 5.0, so I think we should already go ahead and merge this even without having #4667 merged (since that's just an enhancement)

@ocaisa
Copy link
Member

ocaisa commented Nov 6, 2024

#4667 is ready to merge IMHO, it includes tests. If we make easystack support stable then that PR would introduce an unintended regression

@boegel
Copy link
Member Author

boegel commented Nov 6, 2024

#4667 is ready to merge IMHO, it includes tests. If we make easystack support stable then that PR would introduce an unintended regression

@ocaisa You're right, I've merged #4667, so I think this is good to go too (the changes in #4667 will be collapsed into 5.0.x branch, or the other way around, soon)

@ocaisa ocaisa merged commit 48bdb94 into easybuilders:5.0.x Nov 6, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants