Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up stray regex.search in test_checksum_step #4345

Merged
merged 1 commit into from
Sep 11, 2023
Merged

clean up stray regex.search in test_checksum_step #4345

merged 1 commit into from
Sep 11, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Sep 11, 2023

@boegel boegel added this to the next release (4.8.2?) milestone Sep 11, 2023
@boegel boegel changed the title clean up stray regex.search in test_checksum_step clean up stray regex.search in test_checksum_step Sep 11, 2023
@boegel boegel mentioned this pull request Sep 11, 2023
Merged
SebastianAchilles
SebastianAchilles approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @boegel!

@SebastianAchilles SebastianAchilles merged commit 0546463 into easybuilders:develop Sep 11, 2023
42 checks passed
@boegel boegel deleted the test_checksum_step_cleanup branch September 14, 2023 09:23
@PetrKralCZ PetrKralCZ mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees
No one assigned
Labels
code cleanup tests
Projects
None yet
Milestone
4.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @SebastianAchilles