Setting checksums to [None] logs an error and continues

[PetrKralCZ]

When using

checksums = [None]

Easybuild logs an error

ERROR EasyBuild crashed with an error (at easybuild/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): Couldn't find file checksums.json anywhere, and downloading it is disabled

but the build process continues and eventually finishes successfully.

[PetrKralCZ]

related to #4142

[boegel]

This is caused by the try/except setup here:

easybuild-framework/easybuild/framework/easyblock.py

Lines 398 to 405 in b1a5287

	try:
	path = self.obtain_file("checksums.json", no_download=True)
	self.log.info("Loading checksums from file %s", path)
	json_txt = read_file(path)
	self.json_checksums = json.loads(json_txt)
	# if the file can't be found, return an empty dict
	except EasyBuildError:
	self.json_checksums = {}

obtain_file raises an error if the file can't be found, which is caught there

We should instead somehow specify that obtain_file should try to find the file, and just log a warning if it's not found, and returns None.

@PetrKralCZ Are you up for taking a look at that yourself?

[PetrKralCZ]

• avoid error being logged when checksums.json is not found #4261
• clean up stray regex.search in test_checksum_step #4345