Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance extract_cmd function to use 'cp -a' for shell scripts (.sh) #3545

Merged
merged 2 commits into from
Jan 11, 2021
Merged

enhance extract_cmd function to use 'cp -a' for shell scripts (.sh) #3545

merged 2 commits into from
Jan 11, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 10, 2021 •
edited
Loading

This fixes the following issue when trying to install something that only involves a shell script as "source" file:

 Unknown file type for file l_HPCKit_p_2021.1.0.2684_offline.sh

(triggered with easybuilders/easybuild-easyconfigs#11982)

@boegel boegel added this to the next release (4.3.3?) milestone Jan 10, 2021
ocaisa
ocaisa requested changes Jan 11, 2021
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from comment

easybuild/tools/filetools.py Outdated Show resolved Hide resolved
@boegel boegel mentioned this pull request Jan 11, 2021
Merged
ocaisa
ocaisa approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit 3536ac7 into easybuilders:develop Jan 11, 2021
@boegel boegel changed the title enhance extract_cmd functio to use 'cp -a' for shell scripts (.sh) enhance extract_cmd function to use 'cp -a' for shell scripts (.sh) Jan 11, 2021
@boegel boegel deleted the extract_cmd_sh branch January 11, 2021 17:26
@boegel boegel mentioned this pull request Mar 31, 2021
Merged
@branfosj branfosj mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @ocaisa