Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding locking to prevent two parallel builds of the same installation directory #3009

Merged
merged 32 commits into from
Mar 30, 2020
Merged

adding locking to prevent two parallel builds of the same installation directory #3009

merged 32 commits into from
Mar 30, 2020

Commits on Sep 16, 2019

  1. adding a locking feature that will prevent two parallel builds of the… 

    … same installation directory, with an option --wait-on-lock which will cause EB to wait until the lock file is removed, checking every minute for the presence of the lock file.
    @mboisson
    mboisson committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    0260023 View commit details
    Browse the repository at this point in the history

  2. appeasing hound

    @mboisson
    mboisson committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    4311615 View commit details
    Browse the repository at this point in the history

  3. adding silent mode for printed messages to hopefully make tests pass.

    @mboisson
    mboisson committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    0d74bd0 View commit details
    Browse the repository at this point in the history

  4. adding the option to specify the lock path using a global argument

    @mboisson
    mboisson committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    e6bd046 View commit details
    Browse the repository at this point in the history

  5. appeasing hound

    @mboisson
    mboisson committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    e467ba3 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. made one more message silent. changed the default lockpath to use ins… 

    …tall_path
    @mboisson
    mboisson committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    9c725e7 View commit details
    Browse the repository at this point in the history

  2. appeasing hound

    @mboisson
    mboisson committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    dfb9a7b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. fix mkdir of lockpath to include parents

    @mboisson
    mboisson committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    655d494 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Merge branch 'upstream_develop' into build_lock

    @mboisson
    mboisson committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    4e63736 View commit details
    Browse the repository at this point in the history

  2. fixed test for toy_build, given locks

    @mboisson
    mboisson committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    69cf227 View commit details
    Browse the repository at this point in the history

  3. fixing test for toy_build, to take locks into account

    @mboisson
    mboisson committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    21900fc View commit details
    Browse the repository at this point in the history

  4. trying to fix test agian

    @mboisson
    mboisson committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    5efac48 View commit details
    Browse the repository at this point in the history

  5. trying to fix test agian

    @mboisson
    mboisson committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    4edcfd9 View commit details
    Browse the repository at this point in the history

  6. trying to fix test agian

    @mboisson
    mboisson committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    a9038ca View commit details
    Browse the repository at this point in the history

  7. trying to fix test agian

    @mboisson
    mboisson committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    f355c1a View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. bug fix: actually proceed with installation after waiting for lock to… 

    … be released (+ some cleanup)
    @boegel
    boegel committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    a6f92f5 View commit details
    Browse the repository at this point in the history

  2. don't print messages when creating/removing lock, just log an info me… 

    …ssage
    @boegel
    boegel committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    41ad45b View commit details
    Browse the repository at this point in the history

  3. make wait-for-lock interval configurable via --wait-for-lock

    @boegel
    boegel committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    0e7c818 View commit details
    Browse the repository at this point in the history

  4. rename --lockpath to --locks-dir

    @boegel
    boegel committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    fbb7c7f View commit details
    Browse the repository at this point in the history

  5. add test for lock that prevents two identical installations happening… 

    … in parallel
    @boegel
    boegel committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    878d611 View commit details
    Browse the repository at this point in the history

  6. add --ignore-locks option

    @boegel
    boegel committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    79a880a View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. fix broken toy tests, take into account .locks dir in software directory

    @boegel
    boegel committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    9724ed9 View commit details
    Browse the repository at this point in the history

  2. fix failing test_module_only

    @boegel
    boegel committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    5adfc37 View commit details
    Browse the repository at this point in the history

  3. use directory as lock

    @boegel
    boegel committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    f77ced5 View commit details
    Browse the repository at this point in the history

  4. ensure cleaner error when lock dir can't be created

    @boegel
    boegel committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    81f7833 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #20 from boegel/build_lock 

    bug fix, code cleanup + dedicated test for installation lock
    @mboisson
    mboisson authored Mar 30, 2020
    Configuration menu
    Copy the full SHA
    e39976b View commit details
    Browse the repository at this point in the history

  6. enhance lock test to check for clean error

    @boegel
    boegel committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    af2f6e5 View commit details
    Browse the repository at this point in the history

  7. appease the Hound

    @boegel
    boegel committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    5c5d242 View commit details
    Browse the repository at this point in the history

  8. also accept 'Permission denied' error in test for failing lock creation

    @boegel
    boegel committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    774f589 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #21 from boegel/build_lock 

    enhance lock test + appease the Hound
    @mboisson
    mboisson authored Mar 30, 2020
    Configuration menu
    Copy the full SHA
    697ff6e View commit details
    Browse the repository at this point in the history

  10. sort lists before comparing them in test_toy_modaltsoftname

    @boegel
    boegel committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    1b85909 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #22 from boegel/build_lock 

    sort lists before comparing them in test_toy_modaltsoftname
    @mboisson
    mboisson authored Mar 30, 2020
    Configuration menu
    Copy the full SHA
    4b01f31 View commit details
    Browse the repository at this point in the history