adding locking to prevent two parallel builds of the same installation directory #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same installation directory, with an option --wait-on-lock which will cause EB to wait until the lock file is removed, checking every minute for the presence of the lock file.
houndci-bot
reviewed
Sep 16, 2019
|
Mmmm, so I understand that this new code caused tests to fail, but I have trouble figuring out why... Is it because of additional output in the build output ? |
|
Seeking guidance here @boegel and @akesandgren. I believe we want to add the mention of the lock file in the interactive output of EB, but it seems to make all sorts of tests fail because it is unexpected output. How do I fix that ? |
|
I think I found it. I noticed I missed a parameter for print_msg, which (presumably) makes the output silent while in test mode. Submitted a new commit and testing with travis now. |
houndci-bot
reviewed
Sep 16, 2019
houndci-bot
reviewed
Sep 16, 2019
houndci-bot
reviewed
Sep 17, 2019
boegel
requested changes
Mar 9, 2020
boegel
changed the title
akesandgren
previously requested changes
Mar 30, 2020
bug fix, code cleanup + dedicated test for installation lock
enhance lock test + appease the Hound
sort lists before comparing them in test_toy_modaltsoftname
boegel
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with an option --wait-on-lock which will cause EB to wait until the lock file is removed, checking every minute for the presence of the lock file.
This implements a feature for #2952