Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sbarry Config Files changes #5

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

sebastianbarry
Copy link
Contributor

@sebastianbarry sebastianbarry commented Sep 19, 2022

Fixing display errors (duplicate text) for join-pages

nrel-commute.nrel-op.json

  • There was a redundant NREL here, which would make the title of the join-page read: National Renewable Energy Laboratory (NREL) NREL commuting study

wyoming.nrel-op.json

  • Removed the redundant part of the title which caused it to read: Yellowstone-Teton Clean Cities Yellowstone-Teton Clean Cities E-Bike Commuter Program
  • Also changed the spanish translation for the same reason

nrel-commute.nrel-op.json
- There was a redundant NREL here, which would make the title of the join-page read: National Renewable Energy Laboratory (NREL) NREL commuting study

wyoming.nrel-op.json
- Removed the redundant part of the title which caused it to read: Yellowstone-Teton Clean Cities Yellowstone-Teton Clean Cities E-Bike Commuter Program
- Also changed the spanish translation for the same reason
For all config files, I looked at their MOU's and input the research questions from the MOU's
- Wyoming
- Denver CASR
- Massachusets
- Durham (DID NOT HAVE research questions text, so I took the research questions from the current CMS join page)
- Open access (no MOU, took from the current CMS join page)
- Commute Study (no MOU, took from the current CMS join page)
- Stage Program (no MOU, took from the current CMS join page)
- Stage study (no MOU, took from the current CMS join page)
- dev program (no MOU, took from the current CMS join page)
- dev study (no MOU, took from the current CMS join page)
@sebastianbarry sebastianbarry changed the title Fixing display errors (duplicate text) for join-pages Sbarry Config Files changes Sep 20, 2022
@sebastianbarry
Copy link
Contributor Author

Added Research Questions for all config files

For all config files, I looked at their MOU's and input the research questions from the MOU's

  • Wyoming
  • Denver CASR
  • Massachusets
  • Durham (DID NOT HAVE research questions text, so I took the research questions from the current CMS join page)
  • Open access (no MOU, took from the current CMS join page)
  • Commute Study (no MOU, took from the current CMS join page)
  • Stage Program (no MOU, took from the current CMS join page)
  • Stage study (no MOU, took from the current CMS join page)
  • dev program (no MOU, took from the current CMS join page)
  • dev study (no MOU, took from the current CMS join page)

Before, it was a string separated by "." Now it is an array, so that "." can be included in the string without compromising the compartmentalization of the research questions

- Changed this on every config file
@shankari shankari merged commit 4606ab2 into e-mission:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants