-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locations many categories #178
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6df766a
Locations can now have multiple categories
mak001 071db33
Added task to convert has_one to has_many for categories
mak001 a942111
Fixed relations
mak001 03c6b06
Updated task to exclude uncategorized locations
mak001 a8dea87
Fixes tests
mak001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
<?php | ||
|
||
namespace Dynamic\Locator\Tasks; | ||
|
||
use Dynamic\Locator\Location; | ||
use SilverStripe\Dev\BuildTask; | ||
use SilverStripe\ORM\DataObject; | ||
|
||
/** | ||
* Class LocationCategoriesTask | ||
* @package Dynamic\Locator\Tasks | ||
*/ | ||
class LocationCategoriesTask extends BuildTask | ||
{ | ||
|
||
/** | ||
* @var string | ||
*/ | ||
protected $title = 'Location categories to many_many'; | ||
|
||
/** | ||
* @var string | ||
*/ | ||
protected $description = 'Migration task - Converts locations to have multiple categories'; | ||
|
||
/** | ||
* @var bool | ||
*/ | ||
protected $enabled = true; | ||
|
||
/** | ||
* @param $request | ||
*/ | ||
public function run($request) | ||
{ | ||
/** @var DataObject $class */ | ||
$class = ($request->getVar('locationclass')) ? $request->getVar('locationclass') : Location::class; | ||
$class::add_extension(LocationCategoryExtension::class); | ||
|
||
$ct = 0; | ||
|
||
$convert = function (DataObject $location) use (&$ct) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add some checks for instances where a location might not have a category. Could skip the add code then. Also work in some memoization to reduce the number of calls to the db for the categories. |
||
$location->Categories()->add($location->Category()); | ||
$location->write(); | ||
$ct++; | ||
}; | ||
|
||
foreach ($this->iterateLocations($class) as $location) { | ||
$convert($location); | ||
} | ||
|
||
echo "{$ct} categories converted"; | ||
} | ||
|
||
/** | ||
* @param string $class | ||
* @return Generator | ||
*/ | ||
protected function iterateLocations($class) | ||
{ | ||
foreach ($class::get() as $location) { | ||
yield $location; | ||
} | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this method still needed if it's no longer altering the relation list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alteration has been added back in. A typo in a relation array caused the initial problem.