Locations many categories #178
Conversation
| @@ -212,9 +212,7 @@ public function getShowRadius() | |||
| */ | |||
| public function getCategories() | |||
There was a problem hiding this comment.
Is this method still needed if it's no longer altering the relation list?
There was a problem hiding this comment.
The alteration has been added back in. A typo in a relation array caused the initial problem.
tasks/LocationCategoriesTask.php
Outdated
|
|
||
| $ct = 0; | ||
|
|
||
| $convert = function (DataObject $location) use (&$ct) { |
There was a problem hiding this comment.
Let's add some checks for instances where a location might not have a category. Could skip the add code then. Also work in some memoization to reduce the number of calls to the db for the categories.
Attempted to batch add categories to locations Fixed typo in `belongs_many_many` Updated php docs
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
============================================
+ Coverage 72.9% 73.54% +0.63%
- Complexity 83 93 +10
============================================
Files 7 7
Lines 299 310 +11
============================================
+ Hits 218 228 +10
- Misses 81 82 +1
Continue to review full report at Codecov.
|
Resolves #176