-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support latest RDK on devnet #132
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
882ae5e
added algo field to keys struct
mtsitrin a55a9fd
fixed chainID validation. fixed keys algo
mtsitrin 561a4af
fixed merge
mtsitrin 35e0b81
fixes in relayer start
mtsitrin 458696d
added reference to roller github issues
mtsitrin 0fb3ab4
Merge branch 'main' into mtsitrin/81-cant-start-sequencer
mtsitrin 4839f25
using celestia
mtsitrin d324b1d
modified start values:
mtsitrin 2c1164e
added back the override flag by default
mtsitrin ece0174
increased timout for IBC channel creation
mtsitrin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,32 +4,21 @@ import ( | |||||
"fmt" | ||||||
"regexp" | ||||||
|
||||||
"math/big" | ||||||
|
||||||
"github.com/dymensionxyz/roller/cmd/consts" | ||||||
"github.com/dymensionxyz/roller/cmd/utils" | ||||||
"github.com/spf13/cobra" | ||||||
"math/big" | ||||||
) | ||||||
|
||||||
const ( | ||||||
defaultTokenSupply = "1000000000" | ||||||
) | ||||||
|
||||||
func addFlags(cmd *cobra.Command) { | ||||||
cmd.Flags().StringP(FlagNames.HubID, "", StagingHubID, fmt.Sprintf("The ID of the Dymension hub. %s", getAvailableHubsMessage())) | ||||||
cmd.Flags().StringP(FlagNames.RollappBinary, "", "", "The rollapp binary. Should be passed only if you built a custom rollapp") | ||||||
cmd.Flags().StringP(FlagNames.TokenSupply, "", "1000000000", "The total token supply of the RollApp") | ||||||
|
||||||
cmd.PreRunE = func(cmd *cobra.Command, args []string) error { | ||||||
err := verifyHubID(cmd) | ||||||
if err != nil { | ||||||
return err | ||||||
} | ||||||
err = verifyTokenSupply(cmd) | ||||||
if err != nil { | ||||||
return err | ||||||
} | ||||||
rollappID := args[0] | ||||||
if !validateRollAppID(rollappID) { | ||||||
return fmt.Errorf("invalid RollApp ID '%s'. %s", rollappID, getValidRollappIdMessage()) | ||||||
} | ||||||
return nil | ||||||
} | ||||||
cmd.Flags().StringP(FlagNames.TokenSupply, "", defaultTokenSupply, "The total token supply of the RollApp") | ||||||
} | ||||||
|
||||||
func getRollappBinaryPath(cmd *cobra.Command) string { | ||||||
|
@@ -61,9 +50,9 @@ func GetInitConfig(initCmd *cobra.Command, args []string) (utils.RollappConfig, | |||||
}, nil | ||||||
} | ||||||
func getValidRollappIdMessage() string { | ||||||
return "A valid RollApp ID should follow the format 'name_EIP155-version', where 'name' is made up of" + | ||||||
" lowercase English letters, 'EIP155_version' is a 1 to 5 digit number representing the EIP155 rollapp ID, and '" + | ||||||
"version' is a 1 to 5 digit number representing the version. For example: 'mars_9721_1'" | ||||||
return "A valid RollApp ID should follow the format 'rollapp-name_EIP155-revision', where 'rollapp-name' is made up of" + | ||||||
" lowercase English letters, 'EIP155-revision' is a 1 to 5 digit number representing the EIP155 rollapp ID, and '" + | ||||||
"revision' is a 1 to 5 digit number representing the revision. For example: 'mars_9721-1'" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
func getAvailableHubsMessage() string { | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.