feat: support latest RDK on devnet #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Jun 28, 2023
ItayLevyOfficial
approved these changes
Jun 29, 2023
| " lowercase English letters, 'EIP155_version' is a 1 to 5 digit number representing the EIP155 rollapp ID, and '" + | ||
| "version' is a 1 to 5 digit number representing the version. For example: 'mars_9721_1'" | ||
| return "A valid RollApp ID should follow the format 'rollapp-name_EIP155-revision', where 'rollapp-name' is made up of" + | ||
| " lowercase English letters, 'EIP155-revision' is a 1 to 5 digit number representing the EIP155 rollapp ID, and '" + |
There was a problem hiding this comment.
Suggested change
| " lowercase English letters, 'EIP155-revision' is a 1 to 5 digit number representing the EIP155 rollapp ID, and '" + | |
| " lowercase English letters, 'EIP155-revision' a number up to the length of 5 digits representing the EIP155 rollapp id, and '" + |
| "version' is a 1 to 5 digit number representing the version. For example: 'mars_9721_1'" | ||
| return "A valid RollApp ID should follow the format 'rollapp-name_EIP155-revision', where 'rollapp-name' is made up of" + | ||
| " lowercase English letters, 'EIP155-revision' is a 1 to 5 digit number representing the EIP155 rollapp ID, and '" + | ||
| "revision' is a 1 to 5 digit number representing the revision. For example: 'mars_9721-1'" |
There was a problem hiding this comment.
Suggested change
| "revision' is a 1 to 5 digit number representing the revision. For example: 'mars_9721-1'" | |
| "revision' is a number up to the length of 5 digits representing the revision. For example: 'mars_9721-1'" |
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: