Add diffcheck flag to validate commands

packages/core/src/apextest/JSONReporter.ts

@@ -64,9 +64,7 @@ const skippedProperties = ['skipRate', 'coveredLines', 'totalLines'];
 const timeProperties = ['testExecutionTimeInMs', 'testTotalTimeInMs', 'commandTimeInMs'];
 
 export class JsonReporter {
-    public format(
-        result: TestResult
-    ): {
+    public format(result: TestResult): {
         summary: object;
         tests: CliTestResult[];
         coverage?: CliCoverageResult;

packages/core/src/apextest/TriggerApexTests.ts

@@ -157,13 +157,14 @@ export default class TriggerApexTests {
             //Fetch Test Results
             let testResult = await retry(
                 async (bail) => {
-                  return  await testService.reportAsyncResults(
+                    return await testService.reportAsyncResults(
                         testRunResult.summary.testRunId,
                         true,
                         this.cancellationTokenSource.token
                     );
-                }, { retries: 2, minTimeout: 3000 });
-
+                },
+                { retries: 2, minTimeout: 3000 }
+            );
 
             this.writeTestOutput(testResult);
             //Collect Failed Tests only if Parallel
@@ -503,9 +504,7 @@ export default class TriggerApexTests {
         return result;
     }
 
-    private async validateForApexCoverage(
-        coverageReport: any
-    ): Promise<{
+    private async validateForApexCoverage(coverageReport: any): Promise<{
         result: boolean;
         message?: string;
         packageTestCoverage?: number;

packages/core/src/artifacts/ArtifactInquirer.ts

@@ -42,9 +42,7 @@ export default class ArtifactInquirer {
      * Gets latest package manifest from artifacts
      * Returns null if unable to find latest package manifest
      */
-    private getLatestPackageManifestFromArtifacts(
-        artifacts: ArtifactFilePaths[]
-    ): {
+    private getLatestPackageManifestFromArtifacts(artifacts: ArtifactFilePaths[]): {
         latestPackageManifest: any;
         pathToLatestPackageManifest: string;
     } {

packages/core/src/iprange/RelaxIPRange.ts

@@ -93,15 +93,16 @@ export default class RelaxIPRange {
         let deployId: AsyncResult;
 
         var zipStream = fs.createReadStream(zipFile);
-        await conn.metadata.deploy(zipStream, { rollbackOnError: true, singlePackage: true }, function (
-            error,
-            result: AsyncResult
-        ) {
-            if (error) {
-                return console.error(error);
+        await conn.metadata.deploy(
+            zipStream,
+            { rollbackOnError: true, singlePackage: true },
+            function (error, result: AsyncResult) {
+                if (error) {
+                    return console.error(error);
+                }
+                deployId = result;
             }
-            deployId = result;
-        });
+        );
 
         let metadata_deploy_result: DeployResult = await this.checkDeploymentStatus(conn, deployId.id);
 

packages/core/src/package/SFPPackage.ts

@@ -155,7 +155,8 @@ export default class SFPPackage {
             sfpPackage._isApexInPackage = packageManifest.isApexInPackage();
             sfpPackage._isProfilesInPackage = packageManifest.isProfilesInPackage();
             sfpPackage._isPermissionSetGroupInPackage = packageManifest.isPermissionSetGroupsFoundInPackage();
-            sfpPackage._isProfileSupportedMetadataInPackage = packageManifest.isPayLoadContainTypesSupportedByProfiles();
+            sfpPackage._isProfileSupportedMetadataInPackage =
+                packageManifest.isPayLoadContainTypesSupportedByProfiles();
 
             let apexFetcher: ApexTypeFetcher = new ApexTypeFetcher(sfpPackage._mdapiDir);
 

packages/core/src/package/coverage/PackageTestCoverage.ts

@@ -75,9 +75,7 @@ export default class PackageTestCoverage {
         return testCoverage;
     }
 
-    public async validateTestCoverage(
-        coverageThreshold?: number
-    ): Promise<{
+    public async validateTestCoverage(coverageThreshold?: number): Promise<{
         result: boolean;
         message?: string;
         packageTestCoverage: number;

packages/core/src/package/packageInstallers/InstallPackage.ts

@@ -19,6 +19,7 @@ export abstract class InstallPackage {
     protected packageDescriptor;
     protected packageDirectory;
     protected org: SFPOrg;
+    private isArtifactToBeCommitted: boolean = true;
 
     public constructor(
         protected sfdxPackage: string,
@@ -139,15 +140,22 @@ export abstract class InstallPackage {
         });
     }
 
+    //Set this to disable whethere info about the artifact has to be recorded in the org
+    public set disableArtifactCommit(disableArtifactCommit: boolean) {
+        this.isArtifactToBeCommitted = !disableArtifactCommit;
+    }
+
     private async commitPackageInstallationStatus() {
-        try {
-            await this.org.updateArtifactInOrg(this.logger, this.packageMetadata);
-        } catch (error) {
-            SFPLogger.log(
-                'Unable to commit information about the package into org..Check whether prerequisities are installed',
-                LoggerLevel.WARN,
-                this.logger
-            );
+        if (this.isArtifactToBeCommitted) {
+            try {
+                await this.org.updateArtifactInOrg(this.logger, this.packageMetadata);
+            } catch (error) {
+                SFPLogger.log(
+                    'Unable to commit information about the package into org..Check whether prerequisities are installed',
+                    LoggerLevel.WARN,
+                    this.logger
+                );
+            }
         }
     }
 

packages/core/src/package/packageInstallers/InstallSourcePackageImpl.ts

@@ -64,16 +64,13 @@ export default class InstallSourcePackageImpl extends InstallPackage {
                 isReconcileErrored = false;
             let profileFolders;
             if (this.packageMetadata.isProfilesFound && this.packageMetadata.reconcileProfiles !== false) {
-                ({
-                    profileFolders,
-                    isReconcileActivated,
-                    isReconcileErrored,
-                } = await this.reconcileProfilesBeforeDeployment(
-                    profileFolders,
-                    this.sourceDirectory,
-                    this.targetusername,
-                    tempDir
-                ));
+                ({ profileFolders, isReconcileActivated, isReconcileErrored } =
+                    await this.reconcileProfilesBeforeDeployment(
+                        profileFolders,
+                        this.sourceDirectory,
+                        this.targetusername,
+                        tempDir
+                    ));
 
                 //Reconcile Failed, Bring back the original profiles
                 if (isReconcileErrored && profileFolders.length > 0) {