Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Add diffcheck flag to validate commands #911

Merged
merged 12 commits into from
Mar 29, 2022
Merged

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Mar 25, 2022

Description

Based on the contribution by @jhawk-4 in #801

  • Add the ability to disable diffcheck that is performed during validation by using a flag on the $sfdx sfpowerscripts:orchestrator:validate and $sfdx sfpowerscripts:orchestrator:validateAgainstOrg commands.

  • Added a flag to disable committing artifact records in the org. This will prevent the issue when a temporary merge (as in case of PR) is being used to validate on a reused org.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

jhawk-4 and others added 2 commits January 5, 2022 11:20
add a --diffcheck flag along with --disableartifactupdate to ensure there are options for the user
to prevent package installation records being updated to the org
@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 March 25, 2022 05:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #911 (ad94dad) into develop (464fdb6) will not change coverage.
The diff coverage is n/a.

❗ Current head ad94dad differs from pull request most recent head 54b2ef1. Consider uploading reports for the commit 54b2ef1 to get more accurate results

@@           Coverage Diff            @@
##           develop     #911   +/-   ##
========================================
  Coverage    80.07%   80.07%           
========================================
  Files           36       36           
  Lines         1104     1104           
  Branches       234      234           
========================================
  Hits           884      884           
  Misses         220      220           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dde0f7...54b2ef1. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam added the enhancement enhancement to existing feature label Mar 27, 2022
@azlam-abdulsalam azlam-abdulsalam added this to the Release - April 2022 milestone Mar 27, 2022
@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 March 28, 2022 23:36
@azlam-abdulsalam azlam-abdulsalam self-assigned this Mar 28, 2022
@azlam-abdulsalam azlam-abdulsalam merged commit f9ec248 into develop Mar 29, 2022
@azlam-abdulsalam azlam-abdulsalam deleted the feat/validate branch March 29, 2022 13:06
@azlam-abdulsalam azlam-abdulsalam removed this from the Release - April 2022 milestone Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for diffcheck parameter in validateAgainstOrg command
4 participants