Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update d.ts #538

Merged
merged 1 commit into from
Feb 6, 2017
Merged

update d.ts #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import {
StoreEnhancer
} from 'redux';


import {History} from "history";
import React from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither is unnecessary.
line 11: @types/react-router has dependency on @types/history, not the one in lib.es6.d.ts.
line 12 imports JSX namespace referenced in line 80.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSX is declared as a global namespace.


export interface onActionFunc {
(api: MiddlewareAPI<any>): void;
}
Expand Down Expand Up @@ -51,7 +55,7 @@ export interface EffectsMapObject {
}

export interface SubscriptionAPI {
history: HistoryModule.History;
history: History;
dispatch: Dispatch<any>;
}

Expand All @@ -68,7 +72,7 @@ export interface Model {
}

export interface RouterAPI {
history: HistoryModule.History;
history: History;
app: DvaInstance;
}

Expand Down
1 change: 1 addition & 0 deletions router.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import useRouterHistory from "react-router/lib/useRouterHistory";
import createMemoryHistory from "react-router/lib/createMemoryHistory";
import withRouter from "react-router/lib/withRouter";
import applyRouterMiddleware from "react-router/lib/applyRouterMiddleware";
import ReactRouter from "react-router";

// PlainRoute is defined in the API documented at:
// https://github.com/rackt/react-router/blob/master/docs/API.md
Expand Down