Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update d.ts #538

Merged
merged 1 commit into from
Feb 6, 2017
Merged

update d.ts #538

merged 1 commit into from
Feb 6, 2017

Conversation

pvtyuan
Copy link
Contributor

@pvtyuan pvtyuan commented Jan 23, 2017

update d.ts

@coveralls
Copy link

coveralls commented Jan 23, 2017

Coverage Status

Coverage remained the same at 94.643% when pulling c61e073 on pvtyuan:master into 33a276a on dvajs:master.

@@ -7,6 +7,10 @@ import {
StoreEnhancer
} from 'redux';


import {History} from "history";
import React from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither is unnecessary.
line 11: @types/react-router has dependency on @types/history, not the one in lib.es6.d.ts.
line 12 imports JSX namespace referenced in line 80.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSX is declared as a global namespace.

@sorrycc sorrycc merged commit 0a1d954 into dvajs:master Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants