-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require count attribute in response #143
Do not require count attribute in response #143
Conversation
Thanks @kevinwmerritt. I quickly scanned through this and I think I prefer a unit test rather than a full integration test which is more or less a copy of the pagination tests. I can write the test but I can I only do it in a couple of days. |
@@ -104,6 +104,26 @@ export default DRFSerializer.extend({ | |||
}); | |||
``` | |||
|
|||
## Cursor Pagination | |||
|
|||
To use `CursorPagination`, override `extractPageNumber` in the serializer to extract the `cursor`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link this to the DRF docs on cursor pagination? ☝️
http://www.django-rest-framework.org/api-guide/pagination/#cursorpagination
Thanks for this—and especially for adding to the docs! I agree with Ben, the duplicated acceptance test module with |
3ebfb59
to
0e021a6
Compare
@benkonrath I updated the PR with @dustinfarris's suggestion to use a unit test instead of the acceptance test. |
0e021a6
to
a03d135
Compare
LGTM |
Do not require count attribute in response
@kevinwmerritt for some reason I thought I had your contact information already, but it appears I don't. Would you mind shooting me an email? [email protected] |
I just checked it over too - looks good. Thanks guys! |
👍 |
I removed the requirement to have a
count
attribute in the DRF list response.This closes #136