Do not require the count attribute to be present

[kevinwmerritt]

When using cursor pagination the count attribute is not included by default.
http://www.django-rest-framework.org/api-guide/pagination/#cursorpagination

This one line change is required for cursor pagination to work. The count attribute was not required before 1.0.

[kevinwmerritt]

I misspoke. Before 1.0 I did have to override extractPageNumber in the serializer.

  extractPageNumber: function(url) {
    var match = /.*?[\?&]cursor=([A-Za-z0-9]+).*?/.exec(url);
    if (match) {
      return match[1];
    }
    return null;
  },

[benkonrath]

@kevinwmerritt Thanks for your PR and comments. Do you think there's a way to support both CursorPagination and PageNumberPagination without the implementations interfering too much?

[dustinfarris]

I think he's saying that both will work if the check for count is removed. Is that right, @kevinwmerritt?

[kevinwmerritt]

@dustinfarris correct. Removing the check for count allows PageNumberPagination and CursorPagination to work out of the box.

[benkonrath]

Ok, got it. Thanks.

@kevinwmerritt Can you add a test to ensure the count check doesn't creep in again? One idea for this test is to test that normalizeResponse sets up the meta hash when count is present and not present. Let me know if you run into problems with writing the test and I'll try to help.

[benkonrath]

@kevinwmerritt It would also be nice to get your extractPageNumber override into the docs for CursorPagination if you're ok with it.

[dustinfarris]

@kevinwmerritt are you able to make the changes @benkonrath suggested?

[kevinwmerritt]

@dustinfarris Yes. I think I can get to it this week. I can close this PR for now.

[dustinfarris]

Did you mean to close this?

[dustinfarris]

Hi @kevinwmerritt. Any update here?

[kevinwmerritt]

Closing in favor of #143