Mempool should discard any transaction with repeated nullifier #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autholykos
approved these changes
May 5, 2022
pkg/core/mempool.md
Outdated
| ## Implementation details | ||
|
|
||
| ### Exposed methods | ||
| Mempool exposes `ProcessTx` method that is concurrent-safe, implements trasaction acceptance criteria and adds valid transaction to the mempool state. |
There was a problem hiding this comment.
s/trasaction/transaction/
s/valid transaction/valid transactions/
pkg/core/mempool.md
Outdated
| - Block Accepted event triggered by Chain component. | ||
|
|
||
| `PropagateLoop` goroutine handles: | ||
| - any request for transaction repropagation sent by `ProcessTx` and repropagates at proper rate. It also should prioritize propagation by transaction fee (not implemented). |
There was a problem hiding this comment.
Here you can maybe add github issue for transaction prioritization (#1240)
Comment on lines
+249
to
+251
| if err != nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
should we really fail silently here? What to do if data is corrupted?
There was a problem hiding this comment.
m.data represents transactions that pass all checks and are accepted in mempool. If for some odd case m.data has accepted a corrupted tx, this (ContainAnyNullifiers) should not fail here, disallowing acceptance of other valid transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1388