Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mempool should discard any transaction with repeated nullifier #1388

Closed
goshawk-3 opened this issue May 5, 2022 · 0 comments · Fixed by #1389
Closed

Mempool should discard any transaction with repeated nullifier #1388

goshawk-3 opened this issue May 5, 2022 · 0 comments · Fixed by #1389
Assignees

Comments

@goshawk-3
Copy link
Contributor

goshawk-3 commented May 5, 2022

Describe what you want implemented
On transaction retrieval, Mempool should check if any of transaction nullifiers is already used by another transaction in mempool state. The check should be executed after a successful rusk.Preverify call.

Describe "Why" this is needed
This change will allow a block generator for passing transactions to EST without repeated nullifiers. Additionally, mempool will not need anymore to run a cumbersome discardUsedNullifiers at any block acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant