Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp NFT to new sector spell design structure #4668

Merged
merged 45 commits into from
Nov 22, 2023

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Oct 24, 2023

Adapt the NFT sector top level models after the discussion in #4637

The structure:

  • platform models (blur_ethereum_base_trades.sql) - base schema, materialized
  • chain union (nft_ethereum_base_trades.sql) - base schema, view
  • full union (nft_base_trades.sql) - base schema, materialized
  • enrichment (nft_trades_beta.sql) - full schema, view

specific to NFT, a final layer on top to keep compatibility to the currently exposed column names:

  • backwards port (nft_trades.sql) - full schema (old), view, exposed on Dune

@0xRobin 0xRobin changed the title Revamp NFT sector to new spell design guidelines Revamp NFT to new sector spell design structure Oct 24, 2023
@0xRobin
Copy link
Collaborator Author

0xRobin commented Oct 26, 2023

Hmm. can't figure our where this error is coming from..
image

@jeff-dude jeff-dude added the dbt: nft covers the NFT dbt subproject label Nov 15, 2023
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, last piece of feedback i think 🤞

check out the warnings in the dbt compile step of CI. i've noticed this a few times on recent merges, where we forget to check there and then the warnings pop up in prod / user's local setups once syncing with main branch. can you look to clean those warnings up here?

@jeff-dude
Copy link
Member

i merged in #4848 since we've had warnings pop through often post version upgrade. now you can see CI fail on that step.

@0xRobin
Copy link
Collaborator Author

0xRobin commented Nov 21, 2023

it's weird that I don't get this compile warning locally.. 🤔

@jeff-dude
Copy link
Member

it's weird that I don't get this compile warning locally.. 🤔

yeah, i've noticed that too sometimes. usually the warnings i see in CI end up being true gaps though. let me know if that isn't the case here and something else odd is going on

@0xRobin
Copy link
Collaborator Author

0xRobin commented Nov 21, 2023

I was able to get them locally now, might be a partial of full parse thing.
Downside, the current CI setup is "fail-fast" meaning you only get to see the first warning..
There doesn't seem to be an option to make it error but not exit on warnings though.

@jeff-dude
Copy link
Member

I was able to get them locally now, might be a partial of full parse thing. Downside, the current CI setup is "fail-fast" meaning you only get to see the first warning.. There doesn't seem to be an option to make it error but not exit on warnings though.

yep, i had to do:
dbt clean
dbt deps
dbt compile

i should probably alias that locally to run all three every time i do dbt compile

Downside, the current CI setup is "fail-fast" meaning you only get to see the first warning..
There doesn't seem to be an option to make it error but not exit on warnings though.

agree on this, but at the same time, this should be relatively rare. your PR is unique in terms of moving / restructuring, ideally that is less often and/or us internally doing the heavy lifting on that.

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Nov 21, 2023
@jeff-dude jeff-dude merged commit ee5b842 into duneanalytics:main Nov 22, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@0xRobin 0xRobin deleted the nft-sector-design branch May 20, 2024 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: nft covers the NFT dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants