-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp NFT to new sector spell design structure #4668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, last piece of feedback i think 🤞
check out the warnings in the dbt compile step of CI. i've noticed this a few times on recent merges, where we forget to check there and then the warnings pop up in prod / user's local setups once syncing with main branch. can you look to clean those warnings up here?
i merged in #4848 since we've had warnings pop through often post version upgrade. now you can see CI fail on that step. |
it's weird that I don't get this compile warning locally.. 🤔 |
yeah, i've noticed that too sometimes. usually the warnings i see in CI end up being true gaps though. let me know if that isn't the case here and something else odd is going on |
I was able to get them locally now, might be a partial of full parse thing. |
yep, i had to do: i should probably alias that locally to run all three every time i do
agree on this, but at the same time, this should be relatively rare. your PR is unique in terms of moving / restructuring, ideally that is less often and/or us internally doing the heavy lifting on that. |
Adapt the NFT sector top level models after the discussion in #4637
The structure:
blur_ethereum_base_trades.sql
) - base schema, materializednft_ethereum_base_trades.sql
) - base schema, viewnft_base_trades.sql
) - base schema, materializednft_trades_beta.sql
) - full schema, viewspecific to NFT, a final layer on top to keep compatibility to the currently exposed column names:
nft_trades.sql
) - full schema (old), view, exposed on Dune