SPE-243 CI workflow: clean up dbt compile warnings and apply forced error #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-dude
added
the
ready-for-review
This reverts commit 7c72271.
|
tested failure with 7c72271, and |
jeff-dude
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we've upgraded dbt version, we've seen more warnings during
dbt compile. they are easy to overlook in CI workflow, then appear in prod / local setups after merge into main branch. we then have to retroactively clean up those warnings. this change is intended to force failure in gh workflow, so users are aware to fix prior to merge.