Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subtitle #3592

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update subtitle #3592

merged 1 commit into from
Nov 19, 2024

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Nov 19, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1208697680588906/f

Description:
Update app metadata. It was already included in https://github.com/duckduckgo/iOS/releases/tag/7.144.0 but the change was never merged back to main.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@miasma13 miasma13 merged commit b8f782f into main Nov 19, 2024
41 checks passed
@miasma13 miasma13 deleted the michal/update-metadata branch November 19, 2024 11:00
samsymons added a commit that referenced this pull request Nov 21, 2024
…g-error

# By Mariusz Śpiewak (4) and others
# Via GitHub (1) and Mariusz Śpiewak (1)
* main:
  Re-prompt for crash reporting (#3595)
  Fix running BoolFileMarkerTest on device (#3601)
  Run Sync e2e tests only on latest version (#3602)
  Release 7.146.0-1 (#3600)
  Fix autofill search authentication looping (#3598)
  Fix invalid OmniBar state transition on loading  (#3599)
  Update autoconsent to v11.5.0 (#3581)
  Release 7.146.0-0 (#3594)
  deps: Bump [email protected] and BSK@211 (#3588)
  Update subtitle (#3592)
  Limits TipKit availability to iOS 18+ (#3589)
  Fix alpha build compilation (#3584)
  Update VPN auth token check logic (#3585)
  Fix button shapes on New Tab Page (#3586)
  Temporarily disable TipKit (#3564)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants