Limits TipKit availability to iOS 18+ #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
reviewed
Nov 18, 2024
| @@ -256,7 +256,7 @@ struct NetworkProtectionStatusView: View { | |||
| .listRowBackground(Color(designSystemColor: .surface)) | |||
|
|
|||
| Section { | |||
| if #available(iOS 17.0, *) { | |||
| if #available(iOS 17.8, *) { | |||
There was a problem hiding this comment.
Should this use iOS 18 instead?
Suggested change
| if #available(iOS 17.8, *) { | |
| if #available(iOS 18.0, *) { |
There was a problem hiding this comment.
This is right, good eye.
I noticed had suggested a change after pushing the commit myself too... more coffeeeeee!
samsymons
approved these changes
Nov 18, 2024
samsymons
added a commit
that referenced
this pull request
Nov 21, 2024
…g-error # By Mariusz Śpiewak (4) and others # Via GitHub (1) and Mariusz Śpiewak (1) * main: Re-prompt for crash reporting (#3595) Fix running BoolFileMarkerTest on device (#3601) Run Sync e2e tests only on latest version (#3602) Release 7.146.0-1 (#3600) Fix autofill search authentication looping (#3598) Fix invalid OmniBar state transition on loading (#3599) Update autoconsent to v11.5.0 (#3581) Release 7.146.0-0 (#3594) deps: Bump [email protected] and BSK@211 (#3588) Update subtitle (#3592) Limits TipKit availability to iOS 18+ (#3589) Fix alpha build compilation (#3584) Update VPN auth token check logic (#3585) Fix button shapes on New Tab Page (#3586) Temporarily disable TipKit (#3564) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: this is open for review, but DO NOT MERGE until we can point at the internal release branch.
Task/Issue URL: https://app.asana.com/0/1206580121312550/1208786321276837/f
Description
Two changes are introduces here:
setupcall at startup.Steps to test this PR:
Test our tips work well.
Remember you can reset TipKit at the bottom of our debug menu.
Definition of Done (Internal Only):
Internal references:
Software Engineering Expectations
Technical Design Template