Ensure toast closures are called on the main thread #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Sep 12, 2024
samsymons
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Ensure toast closures are called on the main thread (#3347) Update survey builder OS version (#3348) BSK - Add feature flag for SKAN API (#3356) Remove checking for negative attribution case (#3355) C.S.S Bump (Via BSK) (#3346) Update Onboarding gradients (#3350) Alessandro/onboarding copy and private search options (#3349) Onboarding Intro - Add choose address bar position (#3340)
samsymons
added a commit
that referenced
this pull request
Sep 13, 2024
# By Alessandro Boron (7) and others # Via Bartek Waresiak (1) and others * main: (31 commits) Add Marketplace Postback handling (#3357) SKAD4 crash fix (#3361) Enroll all internal users in experiment && Update BSK (#3359) update for macOS: visited links (#3353) Ensure toast closures are called on the main thread (#3347) Update survey builder OS version (#3348) BSK - Add feature flag for SKAN API (#3356) Remove checking for negative attribution case (#3355) C.S.S Bump (Via BSK) (#3346) Update Onboarding gradients (#3350) Alessandro/onboarding copy and private search options (#3349) Onboarding Intro - Add choose address bar position (#3340) Fix PrivacyDashboard appearance on entering foreground (#3345) Improve Data Store ID managing (#3335) Alessandro/onboarding choose app icon (#3330) Fix Localizable strings (#3341) Move lazy var access to the MainActor (#3333) Release 7.137.0-2 (#3344) Fix privacy icon glitch (#3343) BSK bump for macOS password import promotion flow (#3332) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1164476816987988/1208244627536574/f
Tech Design URL:
CC: @jaceklyp @samsymons
Description:
Steps to test this PR:
lastToastShownDateto.distantPastinBrokenSitePromptLimiter.swift. Optionally comment line 95 in that file to have the toast shown every timeDefinition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template