Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alessandro/onboarding copy and private search options #3349

Merged

Conversation

alessandroboron
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1208241563982253

Description:

  1. Remove anonymous searches Option 3 for Highlights experiment.
  2. Update anonymous search Surprise Me to search for “baby ducklings” for both US and International.
  3. Update copy throughout the App for Highlights experiment.

Steps to test this PR:

Prerequisites:

  • Add return VariantIOS(name: "mb", weight: 1, isIncluded: VariantIOS.When.always, features: [.newOnboardingIntro]) in DefaultVariantManager.swift at line 153.

SCENARIO 1 - Anonymous Search Option 3 - Experiment group

  1. Change var isOnboardingHighlightsEnabled: Bool { true } in OnboardingManager line 44.
  2. Delete App.
  3. Launch App.
  4. Pass the Onboarding Intro.
  5. Wait fro Try a search dialog to appear.
    Expected Result: “local weather” should not be an option.

SCENARIO 2 - Anonymous Search Option 3 - Control group

  1. Ensure that isOnboardingHighlightsEnabled returns false in OnboardingManager line 44.
  2. Delete App.
  3. Launch App.
  4. Pass the Onboarding Intro.
  5. Wait fro Try a search dialog to appear.
    Expected Result: “local weather” should be an option and in position 3.

SCENARIO 3 - Anonymous Search Surprise Me - Experiment Group

  1. Change var isOnboardingHighlightsEnabled: Bool { true } in OnboardingManager line 44.
  2. Delete App.
  3. Launch App.
  4. Pass the Onboarding Intro.
  5. Wait fro Try a search dialog to appear.
  6. Tap on “Surprise Me"
    Expected Result: The browser should perform a search for "baby ducklings”

SCENARIO 3 - Anonymous Search Surprise Me - Control Group

  1. Ensure isOnboardingHighlightsEnabled returns false in OnboardingManager line 44.
  2. Delete App.
  3. Launch App.
  4. Pass the Onboarding Intro.
  5. Wait fro Try a search dialog to appear.
  6. Tap on “Surprise Me"
    Expected Result: The browser should perform a search for "dinner recipes” for non US countries, "chocolate chip cookie recipes” for US.

SCENARIO 4 - Copy Update

  1. Smoke test the App and check the copy look like the design.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@alessandroboron alessandroboron force-pushed the alessandro/onboarding-copy-and-private-search-options branch from a9f0d15 to 640edd3 Compare September 11, 2024 08:03
Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from alessandro/onboarding-choose-address-bar-position to main September 11, 2024 23:50
@alessandroboron alessandroboron force-pushed the alessandro/onboarding-copy-and-private-search-options branch from 640edd3 to 27ea36b Compare September 11, 2024 23:52
@alessandroboron alessandroboron merged commit e4e52c2 into main Sep 12, 2024
13 checks passed
@alessandroboron alessandroboron deleted the alessandro/onboarding-copy-and-private-search-options branch September 12, 2024 00:02
samsymons added a commit that referenced this pull request Sep 12, 2024
# By Alessandro Boron (3) and others
# Via GitHub
* main:
  BSK - Add feature flag for SKAN API (#3356)
  Remove checking for negative attribution case  (#3355)
  C.S.S Bump (Via BSK) (#3346)
  Update Onboarding gradients (#3350)
  Alessandro/onboarding copy and private search options (#3349)
  Onboarding Intro - Add choose address bar position (#3340)
  Fix PrivacyDashboard appearance on entering foreground (#3345)
  Improve Data Store ID managing (#3335)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Sep 13, 2024
* main:
  Ensure toast closures are called on the main thread (#3347)
  Update survey builder OS version (#3348)
  BSK - Add feature flag for SKAN API (#3356)
  Remove checking for negative attribution case  (#3355)
  C.S.S Bump (Via BSK) (#3346)
  Update Onboarding gradients (#3350)
  Alessandro/onboarding copy and private search options (#3349)
  Onboarding Intro - Add choose address bar position (#3340)
samsymons added a commit that referenced this pull request Sep 13, 2024
# By Alessandro Boron (7) and others
# Via Bartek Waresiak (1) and others
* main: (31 commits)
  Add Marketplace Postback handling (#3357)
  SKAD4 crash fix (#3361)
  Enroll all internal users in experiment && Update BSK (#3359)
  update for macOS: visited links (#3353)
  Ensure toast closures are called on the main thread (#3347)
  Update survey builder OS version (#3348)
  BSK - Add feature flag for SKAN API (#3356)
  Remove checking for negative attribution case  (#3355)
  C.S.S Bump (Via BSK) (#3346)
  Update Onboarding gradients (#3350)
  Alessandro/onboarding copy and private search options (#3349)
  Onboarding Intro - Add choose address bar position (#3340)
  Fix PrivacyDashboard appearance on entering foreground (#3345)
  Improve Data Store ID managing (#3335)
  Alessandro/onboarding choose app icon (#3330)
  Fix Localizable strings (#3341)
  Move lazy var access to the MainActor (#3333)
  Release 7.137.0-2 (#3344)
  Fix privacy icon glitch (#3343)
  BSK bump for macOS password import promotion flow (#3332)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants