-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alessandro/onboarding copy and private search options #3349
Merged
alessandroboron
merged 6 commits into
main
from
alessandro/onboarding-copy-and-private-search-options
Sep 12, 2024
Merged
Alessandro/onboarding copy and private search options #3349
alessandroboron
merged 6 commits into
main
from
alessandro/onboarding-copy-and-private-search-options
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroboron
force-pushed
the
alessandro/onboarding-copy-and-private-search-options
branch
from
September 11, 2024 08:03
a9f0d15
to
640edd3
Compare
SabrinaTardio
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Base automatically changed from
alessandro/onboarding-choose-address-bar-position
to
main
September 11, 2024 23:50
alessandroboron
force-pushed
the
alessandro/onboarding-copy-and-private-search-options
branch
from
September 11, 2024 23:52
640edd3
to
27ea36b
Compare
alessandroboron
deleted the
alessandro/onboarding-copy-and-private-search-options
branch
September 12, 2024 00:02
samsymons
added a commit
that referenced
this pull request
Sep 12, 2024
# By Alessandro Boron (3) and others # Via GitHub * main: BSK - Add feature flag for SKAN API (#3356) Remove checking for negative attribution case (#3355) C.S.S Bump (Via BSK) (#3346) Update Onboarding gradients (#3350) Alessandro/onboarding copy and private search options (#3349) Onboarding Intro - Add choose address bar position (#3340) Fix PrivacyDashboard appearance on entering foreground (#3345) Improve Data Store ID managing (#3335) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Ensure toast closures are called on the main thread (#3347) Update survey builder OS version (#3348) BSK - Add feature flag for SKAN API (#3356) Remove checking for negative attribution case (#3355) C.S.S Bump (Via BSK) (#3346) Update Onboarding gradients (#3350) Alessandro/onboarding copy and private search options (#3349) Onboarding Intro - Add choose address bar position (#3340)
samsymons
added a commit
that referenced
this pull request
Sep 13, 2024
# By Alessandro Boron (7) and others # Via Bartek Waresiak (1) and others * main: (31 commits) Add Marketplace Postback handling (#3357) SKAD4 crash fix (#3361) Enroll all internal users in experiment && Update BSK (#3359) update for macOS: visited links (#3353) Ensure toast closures are called on the main thread (#3347) Update survey builder OS version (#3348) BSK - Add feature flag for SKAN API (#3356) Remove checking for negative attribution case (#3355) C.S.S Bump (Via BSK) (#3346) Update Onboarding gradients (#3350) Alessandro/onboarding copy and private search options (#3349) Onboarding Intro - Add choose address bar position (#3340) Fix PrivacyDashboard appearance on entering foreground (#3345) Improve Data Store ID managing (#3335) Alessandro/onboarding choose app icon (#3330) Fix Localizable strings (#3341) Move lazy var access to the MainActor (#3333) Release 7.137.0-2 (#3344) Fix privacy icon glitch (#3343) BSK bump for macOS password import promotion flow (#3332) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208241563982253
Description:
Steps to test this PR:
Prerequisites:
return VariantIOS(name: "mb", weight: 1, isIncluded: VariantIOS.When.always, features: [.newOnboardingIntro])
inDefaultVariantManager.swift
at line 153.SCENARIO 1 - Anonymous Search Option 3 - Experiment group
var isOnboardingHighlightsEnabled: Bool { true }
inOnboardingManager
line 44.Expected Result: “local weather” should not be an option.
SCENARIO 2 - Anonymous Search Option 3 - Control group
isOnboardingHighlightsEnabled
returnsfalse
inOnboardingManager
line 44.Expected Result: “local weather” should be an option and in position 3.
SCENARIO 3 - Anonymous Search Surprise Me - Experiment Group
var isOnboardingHighlightsEnabled: Bool { true }
inOnboardingManager
line 44.Expected Result: The browser should perform a search for "baby ducklings”
SCENARIO 3 - Anonymous Search Surprise Me - Control Group
isOnboardingHighlightsEnabled
returnsfalse
inOnboardingManager
line 44.Expected Result: The browser should perform a search for "dinner recipes” for non US countries, "chocolate chip cookie recipes” for US.
SCENARIO 4 - Copy Update
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template