Bikegeek patch 1 #279
Closed
Bikegeek patch 1 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Issue #221 Replace the ERROR with a WARNING and proceed when a password is missing. This allows cloud-users to continue without a password. * Issue #221 Do a separate check, one for username, the other for password. If the username is missing, continue to log an error and raise a NameError. However, if the password is missing, log a warning and continue, to support cloud-based instances. * Fixed extraneous parenthesis in if-statement. * Issue #221 Removed check for missing password. * update warning message, and verified that the check for password no longer exists
Bumps [pip](https://github.com/pypa/pip) from 22.2.2 to 23.3. - [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst) - [Commits](pypa/pip@22.2.2...23.3) --- updated-dependencies: - dependency-name: pip dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#242) * Added 'sphinx_rtd_theme', to extensions * Updating requirements.txt
Bugfix for TC Pairs files not loading into database #260
Bugfix 267 reformat for metcalcpy
* command line updates * Updated checkout@v3 to be checkout@v4 --------- Co-authored-by: Lisa Goodrich <[email protected]>
replace version number with 'develop'
JohnHalleyGotway
added a commit
that referenced
this pull request
Apr 4, 2024
…h that matches the source code branch
JohnHalleyGotway
added a commit
that referenced
this pull request
Apr 4, 2024
bikegeek
added a commit
that referenced
this pull request
Apr 4, 2024
* Per #289, add draft sonarqube.xml workflow. * Per #289, add logic for handling the sonar-project.properties file. * Per #289, remove scanning of my feature branch and also tweak run script. * Per #289, update the run_sonarqube.sh script to check that SONAR_TOKEN and SONAR_HOST_URL are both set. * Per #289, add logic to define SONAR_PROJECT_VERSION * Per #289 fix typo in ProjectName where METdatio should really be METdataio * Per #273, fix typo in properties file * Per #279, update run_sonarqube.sh script to push to a SonarQube branch that matches the source code branch * Per #279, update the PR template. * Per #289, remove the internal_tests directory which only contains files for SonarQube. These have been relocated to internal/scripts/sonarqube for consistency with other METplus repos. I checked the crontab entry on seneca for the met_test user that the latter version is used, and not this one I'm deleting. * Issue #289 Added METreformat to the list of sonar.sources --------- Co-authored-by: bikegeek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes