Bugfix 221 empty password

[bikegeek]

Pull Request Testing

• Describe testing already performed for these changes:
  
  Passes the Github workflow tests for METreformat, which use the code (but not the db loading aspect)

testing done on code in the bugfix_221_empty_password branch

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  verify this works on an AWS instance using the bugfix_221_empty_password branch

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

• Do these changes include sufficient testing updates? [NA]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by At earliest convenience, since this is a blocker.
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[TatianaBurek]

I successfully tested the new code.
I asked Binbin to do a complete test from WCOSS

[TatianaBurek]

The warning message still contains word "password"

[bikegeek]

that is strange, I see this in the repo: 4c1ca2f Updated the warning message and verified that the error check for password is not present in a "fresh" checkout. Re-committed. I'll try re-committing and see if that works. --------------- Minna Win Pronouns: she/her National Center for Atmospheric Research Research Applications Lab Developmental Testbed Center Phone: 303-497-8423 Fax: 303-497-8401 ---------------

…

On Mon, Aug 7, 2023 at 12:28 PM Tatiana Burek ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In METdbLoad/ush/read_load_xml.py <#222 (comment)>: > @@ -239,10 +239,10 @@ def read_db_connect(self, root): root.xpath('connection')[0].xpath('user')[0].text self.connection['db_password'] = \ root.xpath('connection')[0].xpath('password')[0].text - if ((not self.connection['db_user']) or - (not self.connection['db_password'])): - logging.error("!!! XML must include user and password tags") - raise NameError("Missing required user or password tag or both") + + if not self.connection['db_user']: + logging.warning("!!! XML expecting user and password tags") The warning message still contains word "password" — Reply to this email directly, view it on GitHub <#222 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4UJHSYFZUDOXJYWWZZQ7TXUEXU5ANCNFSM6AAAAAA3HI6L5A> . You are receiving this because you authored the thread.Message ID: ***@***.***>