Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2401 sonarqube_branch_setting #2491

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Mar 17, 2023

Expected Differences

No changes at MET except the configurations for SonarQube server.

  • Added the branch name to sonarqube configuration file

  • The plain text username and password were replaced with the token which was generated at SonarQube server.
    Note: this is already deployed at seneca a month ago (/d1/projects/MET/MET_regression/MET-develop/internal/scripts/sonarqube/)

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Access http://mandan.rap.ucar.edu:9000/dashboard?id=MET_develop_NB via web browser.
The username and password exist at the old configuration.
image

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

No test. Just checking SonarQube web page.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u linked an issue Mar 17, 2023 that may be closed by this pull request
22 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title #2401 Added branch name Feature #2401 sonarqube_branch_setting Mar 17, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Mar 17, 2023
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this PR.

Makes sense to obfuscate the login information.

@hsoh-u hsoh-u merged commit ba81fc6 into develop Mar 17, 2023
@hsoh-u hsoh-u deleted the feature_2401_sonarqube_branch_setting branch March 23, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Correct the branch name for the SonarQube scanning nightly
2 participants