Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Correct the branch name for the SonarQube scanning nightly #2401

Closed
22 tasks
hsoh-u opened this issue Jan 12, 2023 · 0 comments · Fixed by #2491
Closed
22 tasks

Bugfix: Correct the branch name for the SonarQube scanning nightly #2401

hsoh-u opened this issue Jan 12, 2023 · 0 comments · Fixed by #2491
Assignees
Labels
priority: low Low Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Milestone

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Jan 12, 2023

Replace italics below with details for this issue.

The default branch name for the SonarQube scanning is "master". It should be changed to "develop" branch.

Describe the Problem

Provide a clear and concise description of the bug here.

The branch name for the MET nightly build is "master", not "develop.
SonarQube_branch_name

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

It should be "develop" branch

Environment

Describe your runtime environment:
1. Machine: Linux Workstation
2. OS: RedHat Linux
3. Software version number(s) - MET 11.1 (develop branch) & SonarQube server 9.6.x

To Reproduce

Describe the steps to reproduce the behavior:

  1. Connect VPN (if necessary)
  2. Open a web browser
  3. Access following URL
    http://mandan.rap.ucar.edu:9000/dashboard?id=org.sonarqube%3AMET_develop_NB

Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2771021 AF METplus

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@hsoh-u hsoh-u added type: bug Fix something that is not working priority: low Low Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team labels Jan 12, 2023
@hsoh-u hsoh-u added this to the MET 11.1.0 milestone Jan 12, 2023
@hsoh-u hsoh-u self-assigned this Jan 12, 2023
@hsoh-u hsoh-u moved this from 📋 Backlog to 🏗 In progress in MET-11.1.0 Development Jan 12, 2023
@hsoh-u hsoh-u removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Jan 12, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to ✅ Done in MET-11.1.0 Development Mar 16, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from ✅ Done to 🏗 In progress in MET-11.1.0 Development Mar 16, 2023
@hsoh-u hsoh-u linked a pull request Mar 17, 2023 that will close this issue
15 tasks
@hsoh-u hsoh-u moved this from 🏗 In progress to 👀 In review in MET-11.1.0 Development Mar 17, 2023
hsoh-u added a commit that referenced this issue Mar 17, 2023
@hsoh-u hsoh-u closed this as completed Mar 17, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in MET-11.1.0 Development Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant