Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #2454 #2457

Merged
merged 609 commits into from
Feb 22, 2023
Merged

Update develop-ref after #2454 #2457

merged 609 commits into from
Feb 22, 2023

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

This PR explains the differences flagged by the nightly build in seneca:/d1/projects/MET/MET_regression/develop/NB20230222.

  1. PR Bugfix #2452 develop airnow #2454 for issue Bugfix: Fix inconsistent ASCII2NC AIRNOW location lookup logic #2452 fixes ascii2nc's handling of AIRNOW data and modifies an existing ascii2nc unit test output file.
COMPARING ascii2nc/airnow/HourlyData_20220312.nc
file1: MET-develop-ref/test_output/ascii2nc/airnow/HourlyData_20220312.nc
file2: MET-develop/test_output/ascii2nc/airnow/HourlyData_20220312.nc
ERROR: NetCDF headers differ:
6,7c6,7
< 	nhdr = 3391 ;
< 	nobs = 13078 ;
---
> 	nhdr = 3638 ;
> 	nobs = 13737 ;
9c9
< 	nhdr_sid = 3391 ;
---
> 	nhdr_sid = 3638 ;

Updating develop-ref to get past this expected difference.

jprestop and others added 30 commits August 11, 2022 12:03
* Per issue #2055, in read_grib2_record_list() added new PDS numbers 6, 10, 15 (for NBM data). SL

* Per issue #2055: in read_grib2_record_list(), in section that validates PDS number changed, for undefined PDS numbers, changed Error to Warning and continue (instead of exit). SL

* Per issue #2055, created new entries for NBM grib2 data fields. SL

* Per issue #2055. Added more NBM fields based on a 12z, f003 file. SL

* Per issue #2055, after interogating several NBM lead-time files, added TMAX field. SL

* Per issue #2055, added grib2_nbm.txt to the list. SL

* Per #2055, update the grib2_nbm.txt file entries in the table_files Makefiles.

* Per issue #2055, fixed syntax entry for TSTM field. SL

* Per issue #2055, fixed a few more syntax errors for some of the fields. SL

* Per issue #2055, in read_grib2_record_list(), added section to set level values for template number 6 (NBM data). Also added some temporary print statements. SL

* Per issue  #2055, in read_grib2_record_list(), added code to set levels for table number 10 (like 6). SL

* Per #2055, adding support for new GRIB2_perc_val configuration option to filter records based on the forecast percentile value used by GRIB2 product definition templates 6 and 10. Seth, note that I also included the probability filtering logic tweak we discussed, since it was already present in that same file.

* Per issue #2055: in find_record_matches(), in section that resolves Prob fields, changed 'break' to 'continue' for non Probs. SL

* Per issue #2055, in read_grib2_record_list() cleaned up some commented out code. SL

* Per issue #2055, in read_grib2_record_list() cleaned up all print statements. SL

* Per issue #2055, added 5 new unit tests for NBM data. SL

* Update data2d_grib2.cc

* Update data2d_grib2.cc

Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
…id_stat, gribtab_dat_to_flat, and gsidens2orank). Also removed commented out code from main.cc.
* Per #2198, adding Seth Linden and Dave Albo to the Author List

* Per #2198, updated Dave Albo to David Albo

* Per #2198, added three new authors based on submitted AMS abstract

* Per #2198, adding .zenodo.json file

* Per #2198, adding orcids for all based on Tatiana's suggestion

* Update .zenodo.json

Co-authored-by: johnhg <[email protected]>

* Update .zenodo.json

Co-authored-by: johnhg <[email protected]>

* Update .zenodo.json

Co-authored-by: johnhg <[email protected]>

Co-authored-by: johnhg <[email protected]>
* Per #2196, update for upgrade to Python 3.8.6

* Updated based on new structure of METbaseimage

* Changed MET_BASE_IMAGE references to MET_BASE_TAG; Added information to the README.md file

* Changed MET_BASE_IMAGE references to MET_BASE_TAG; Updated the version from v1.0 to v1.1

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <[email protected]>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <[email protected]>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <[email protected]>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <[email protected]>

* Per #2196, updating README.md based on suggestions from John HG

Co-authored-by: johnhg <[email protected]>
* creating chapter files

* putting a space in to work through the git add and commit process.

* Changed formatting of one header

Co-authored-by: Lisa Goodrich <[email protected]>
Co-authored-by: jprestop <[email protected]>
* Per issue #2206, for the ECNT line type, added CRPS_EMP_FAIR. SL

* Per issue #2206, for ECNT line type, added CRPS_EMP_FAIR. SL

* Per issue #2206, for ecnt_columns, added CRPS_EMP_FAIR. SL

* Per issue #2206, in write_ecnt_cols(), added crps_emp_fair. SL

* Per issue #2206, in ECNTInfo, added crps_emp_fair. SL

* Per issue #2206, started stubbing code pieced to calculate crps_emp_fair. SL

* Per issue #2206, added new function mean_abs_diff(). SL

* Per issue #2206, in compute_pair_vals() updated the code to calculate crps_emp and crps_emp_fair. SL

* Per issue #2206, added crps_emp_fair (CRPS_EMP_FAIR) to relevant code pieces. SL

* Per issue #2206, added wording for CRPS_EMP_FAIR, also added it to last column of ECNT line type. SL

* Per issue #2206, added info for CRPS_EMP_FAIR and also added the math equation for this. SL

* Per issue #2206, update the math equation for CRPS_EMP_FAIR. SL

* Per issue #2206, added new function weighted_mean_absolute_diff(). SL

* Per issue #2206, updated the crps_emp_fair calculation to subtract the weighted_mean_abs_diff. SL

* Per issue #2206, in aggr_orank_lines(), updated calculation for crps_emp_fair to use weighted_mean_abs_diff. SL

* Per issue #2206, renamed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, in aggr_orank_lines(), for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, updated the math equation for the CRPS_EMP_FAIR calculation. SL

* Per issue #2206, fixed a bug in the wmean_abs_diff() function. SL

* Per issue #2206, added code for crps_emp_fair. SL

* Per issue #2206, in set() function, added checks for crps_emp and crps_emp_fair, for values of 0.0. SL

Co-authored-by: Seth Linden <[email protected]>
…r image that it used in the METplus automated tests
…elopment.docker file (apparently unused or rarely previously) to include changes for Python 3.8 including setting the LDFLAG to include -rpath to prevent needing LD_LIBRARY_PATH set to run the tools. Source the env file in the build MET docker script instead of setting the env vars in the configure command
…ck to 3.6. This is done by rolling back the base image in the MET Dockerfiles to dtcenter/met-base:v1.0. Using 3.8 caused the downstream METplus python embedding examples to fail via GHA in the METplus repo. Will write up an issue to investigate more during the MET-11.0.0-beta4 development cycle.
…BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them.
… to MET_BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them."

This reverts commit 5efc65e.
…should really revisit having this setting spread across so many locations.
Howard Soh and others added 27 commits January 23, 2023 14:44
* Updated module and config files

* Reverting to what was in develop
#2218 Initialize polar stereographics parameters for ellipsoidal earth
…interp dictionary. The parse_conf_interp() function supports the method and width entries being defined as arrays. It automatically processes all possible permutations of their values.
Co-authored-by: John Halley Gotway <[email protected]>
Remove pdf from builds and update to Python 3.8
Resetting to old values for now.
Update to Python 38 and turn off pdf option
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Feb 22, 2023
@JohnHalleyGotway JohnHalleyGotway merged commit b0e8151 into develop-ref Feb 22, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Feb 22, 2023 that may be closed by this pull request
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix inconsistent ASCII2NC AIRNOW location lookup logic
9 participants