Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 1749 hss second try #1831

Merged
merged 34 commits into from
Jun 13, 2021
Merged

Feature 1749 hss second try #1831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
a404f9a
Per #1749, updating the MET version number from 10.0 to 10.1 prior to…
JohnHalleyGotway May 26, 2021
bf428d1
Per #1749, adding 10.1 columns to the Makefile.am
JohnHalleyGotway May 26, 2021
eb70070
Per #1749, changes for the mechanics of adding the HSS_EC statistic t…
JohnHalleyGotway May 28, 2021
4c7f62f
Per #1749, add hss_ec_value as a configurable option for Point-Stat a…
JohnHalleyGotway May 28, 2021
912ed2b
Per #1749, fix the column offsets for the HSS_EC columns.
JohnHalleyGotway May 28, 2021
2b63bcb
Per #1749, add correct definition of HSS_EC.
JohnHalleyGotway May 28, 2021
b2d7f2d
Per #1749, pass hss_ec_value from the config file into the computatio…
JohnHalleyGotway May 28, 2021
159b393
Per #1749, add hss_ec_value entry to all the Grid-Stat config files.
JohnHalleyGotway May 28, 2021
98d1f17
Per #1749, update the documentation about the HSS_EC statistic.
JohnHalleyGotway May 28, 2021
02fc34d
Per #1749, add the -hss_ec_value job command option to Stat-Analysis.
JohnHalleyGotway May 28, 2021
f452ae2
Per #1749, no real code changes here. Just changing to consistent ord…
JohnHalleyGotway May 28, 2021
e85a403
Per #1749, update docs for stat_analysis supporting hss_ec_value.
JohnHalleyGotway May 28, 2021
3d254b8
Per #1749, add HSS_EC to Series-Analysis, but only with a constant hs…
JohnHalleyGotway May 28, 2021
4535185
Merge branch 'develop' into feature_1749_hss
JohnHalleyGotway May 28, 2021
87d538d
Per #1749, add EC_VALUE to the MCTC line type definition.
JohnHalleyGotway Jun 9, 2021
0043b98
Per #1749, move ECvalue from the MCTSInfo class into the ContingencyT…
JohnHalleyGotway Jun 9, 2021
3e4508a
Per #1749, update point_stat, grid_stat, and series_analysis to accom…
JohnHalleyGotway Jun 9, 2021
8090805
Per #1749, update library code to write EC_VALUE to the MCTC line typ…
JohnHalleyGotway Jun 9, 2021
1e66dad
Per #1749, update stat_analysis code for the addition of EC_VALUE in …
JohnHalleyGotway Jun 9, 2021
ee705ea
Per #1749, write EC_VALUE to the MCTC output line type.
JohnHalleyGotway Jun 10, 2021
733743e
Per #1749, store the ec_value that was actually used to compute the s…
JohnHalleyGotway Jun 10, 2021
ee02f94
Per #1749, parsing EC_VALUE from the MCTC line type.
JohnHalleyGotway Jun 10, 2021
740504b
Per #1749, move the MCTC EC_VALUE column to the end of the line, as r…
JohnHalleyGotway Jun 10, 2021
ec3b0d4
Per #932, need to write MCTS HSS_EC value to temp file during the boo…
JohnHalleyGotway Jun 11, 2021
5dd348f
Added new reference for Ou 2016
j-opatz Jun 11, 2021
4d8be53
Layout correction
j-opatz Jun 11, 2021
37c728f
Added generalized HSS, removed word from HSS_EC
j-opatz Jun 11, 2021
7761e94
Merge branch 'develop' into feature_1749_hss
JohnHalleyGotway Jun 11, 2021
dd26393
Per #1749, change the hss_ec_value config entry to match new conventi…
JohnHalleyGotway Jun 11, 2021
3b9a01a
Per #1749, fix the bug of writing the MCTC header and data columns us…
JohnHalleyGotway Jun 13, 2021
c2bab0c
Per #1749, simplify the logic so that the expected correct value for …
JohnHalleyGotway Jun 13, 2021
50f0b5f
Per #1749, when computing the MCTS stats, no need to reset ec_value s…
JohnHalleyGotway Jun 13, 2021
6fc2947
Per #1749, updating the Stat-Analysis tests to exercise the the MPR t…
JohnHalleyGotway Jun 13, 2021
f81c5eb
Merging latest from develop into feature_1749_hss for #1749.
JohnHalleyGotway Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion met/src/libcode/vx_statistics/contable.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,16 @@ void ContingencyTable::set_size(int N)

ContingencyTable::set_size(N, N);

//
// if square, set default expected correct value
//

if ( N > 0 ) {

ECvalue = 1.0 / N;

}

return;

}
Expand Down Expand Up @@ -513,7 +523,11 @@ void ContingencyTable::set_ec_value(double v)

{

ECvalue = v;
//
// do not override the default value with bad data
//

if ( !is_bad_data(v) ) ECvalue = v;

return;

Expand Down
8 changes: 0 additions & 8 deletions met/src/libcode/vx_statistics/met_stats.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,14 +626,6 @@ void MCTSInfo::add(double f, double o, double cmn, double csd) {

void MCTSInfo::compute_stats() {

//
// Define the HSS expected correct value, if needed.
// Default to 1 divided by the number of categories.
//
if(is_bad_data(cts.ec_value()) && cts.nrows() > 0) {
cts.set_ec_value(1.0/cts.nrows());
}

acc.v = cts.gaccuracy();
hk.v = cts.gkuiper();
hss.v = cts.gheidke();
Expand Down
2 changes: 1 addition & 1 deletion scripts/fortify/run_nightly.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#=======================================================================

# Constants
EMAIL_LIST="[email protected] [email protected]"
EMAIL_LIST="[email protected] [email protected] [email protected]"
KEEP_DAYS=5

function usage {
Expand Down
2 changes: 1 addition & 1 deletion scripts/regression/test_nightly.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#=======================================================================

# Constants
EMAIL_LIST="[email protected] [email protected]"
EMAIL_LIST="[email protected] [email protected] [email protected]"
KEEP_DAYS=5

# Usage statement
Expand Down
8 changes: 8 additions & 0 deletions test/config/STATAnalysisConfig_point_stat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@ jobs = [
"-job aggregate_stat -fcst_var TMP -fcst_lev Z2 \
-line_type MPR -out_line_type ECLV,CTC,CTS \
-out_thresh >273,>278 -out_eclv_points 0.1",
"-job aggregate_stat -fcst_var TMP -fcst_lev Z2 \
-line_type MPR -out_line_type MCTC \
-out_thresh >273,>275,>277 \
-out_stat ${OUTPUT_DIR}/CONFIG_POINT_STAT_agg_stat_mpr_to_mctc.stat",
"-job aggregate_stat -fcst_var TMP -fcst_lev Z2 \
-line_type MPR -out_line_type MCTS \
-out_thresh >273,>275,>277 -hss_ec_value 0.50 \
-out_stat ${OUTPUT_DIR}/CONFIG_POINT_STAT_agg_stat_mpr_to_mcts.stat",
"-job filter -fcst_var TMP -fcst_lev Z2 \
-line_type MPR -mask_sid ${CONFIG_DIR}/SID_CO.txt \
-dump_row ${OUTPUT_DIR}/CONFIG_POINT_STAT_filter_mpr_sid.stat",
Expand Down