Feature 1749 hss second try #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adding new columns of output to existing line types.
…o the MCTS line type. Still need to acutally compute it and make the expected correct value configurable.
…nd Grid-Stat. Still need to actually compute it correctly, add it to other test config files, add support to series_analysis/stat_analysis, update the docs, and make writeup corresponding issues for other METplus components.
…n of the MCTS statistics.
…ering with hss_ec_value preceeding rank_corr_flag.
…s_ec_value for now.
…able class so that it's available to be included in the MCTC output line type.
…odate the move of ECvalue from the MCTSInfo class to the ContingencyTable class.
…e and update the User's Guide docs.
…the MCTC line type.
…equested by METdatadb.
…tstrapping process.
…ing the wrong indices.
…square contingency tables is initialized to 1/size. Then, prevent that default value from being overriden with bad data.
…ince it was already initialized to a good value when the table was created.
…o MCTC/MCTS conversion both with the default EC value and overriding it using the -hss_ec_value job command.
20 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
I found a bug in the first PR for these changes causing a runtime error from Stat-Analysis. These changes fix that bug.
Added new calls to Stat-Analysis in the unit tests to exercise the logic for that bug.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Stat-Analysis will write 2 new output files.
Please complete this pull request review by [6/13/21].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes