Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MET-11.0.0-beta3 linker errors #2281

Closed
6 of 20 tasks
JohnHalleyGotway opened this issue Sep 28, 2022 · 0 comments · Fixed by #2296
Closed
6 of 20 tasks

Fix MET-11.0.0-beta3 linker errors #2281

JohnHalleyGotway opened this issue Sep 28, 2022 · 0 comments · Fixed by #2296
Assignees
Labels
component: build process Build process issue component: testing Software testing issue priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team requestor: UK Met Office United Kingdom Met Office required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Sep 28, 2022

Describe the Enhancement

@robdarvell reported compilation problems on the UK Met Office Cray machine for both MET versions 11.0.0-beta2 and 11.0.0-beta3. The beta2 issue resulted in #2255 which was fixed for beta3. However, the larger issue of more proactively testing for internal linker issues was not solved. @robdarvell reports a linker error when compiling the GSI Tools related to the newly added -lvx_seeps library.

This issue consists of multiple tasks.

  1. Compile MET version 11.0.0-beta3, as released, in such a way to replicate the linker error reported by the Met Office. This may be done using older versions of compilers and linkers, potentially via Docker containers.
  2. Once successful, consider if/how that test could be automated via GitHub actions to ensure future development does not introduce additional linker issues. This test should be run at least once prior to each release.
  3. Once the error can be replicated, modify the offending Makefile.am files to fix it.

Time Estimate

Unknown

Sub-Issues

Consider breaking the task down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2792541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @jprestop
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: testing Software testing issue component: build process Build process issue requestor: UK Met Office United Kingdom Met Office alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project priority: high High Priority labels Sep 28, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Sep 28, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from Backlog to To Do in MET-11.0.0-beta4 (11/02/22) Sep 28, 2022
@jprestop jprestop removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 4, 2022
jprestop pushed a commit that referenced this issue Oct 5, 2022
…s-needed added to LDFLAGS internal/scripts/environment/development.docker
@jprestop jprestop moved this from To Do to In Progress in MET-11.0.0-beta4 (11/02/22) Oct 6, 2022
jprestop added a commit that referenced this issue Oct 7, 2022
@jprestop jprestop linked a pull request Oct 10, 2022 that will close this issue
15 tasks
Repository owner moved this from In Progress to Done in MET-11.0.0-beta4 (11/02/22) Oct 20, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Create test to replicate MET-11.0.0-beta3 linker errors and fix them Fix the MET-11.0.0-beta3 linker errors Dec 9, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Fix the MET-11.0.0-beta3 linker errors Fix MET-11.0.0-beta3 linker errors Dec 9, 2022
@TaraJensen TaraJensen added reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build process Build process issue component: testing Software testing issue priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team requestor: UK Met Office United Kingdom Met Office required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants