Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pipeline files - Fixes #732 #733

Merged
merged 3 commits into from
Oct 24, 2021
Merged

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Oct 10, 2021

Pull Request (PR) description

This PR updates the pipeline files and the GitHub issue templates to the standards as per this PR against xExchange:
dsccommunity/ExchangeDsc#471

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

@johlju - would you mind reviewing when you have time?


This change is Reviewable

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @PlagueHO)


RequiredModules.psd1, line 21 at r1 (raw file):

'DscResource.Common'        = 'latest'

If this is not necessary (not used by any resource) we should remove the copy part from build, or add it back here.


RequiredModules.psd1, line 23 at r1 (raw file):

NetworkingDsc 

Just double checking, this module is no longer used by any examples and integration tests?


.github/ISSUE_TEMPLATE/Problem_with_resource.yml, line 66 at r1 (raw file):

Quoted 13 lines of code…
  - type: textarea
    id: exchangeVersion
    attributes:
      label: Exchange Server edition and version the target node is running
      description: |
        Please provide as much as possible about the Exchange Server that runs on the target node, for example edition, version, build, and language. _Will be automatically formatted as plain text._

        The following command can help get this information: `Get-ExchangeServer | ft ServerRole, Edition, AdminDisplayVersion`
      placeholder: |
        Add Exchange Server information here
      render: text
    validations:
      required: true

This can be removed.

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Oct 10, 2021
@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #733 (1b281c7) into main (475885c) will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #733   +/-   ##
===================================
- Coverage    72%    72%   -1%     
===================================
  Files        30     30           
  Lines      4427   4427           
===================================
- Hits       3213   3199   -14     
- Misses     1214   1228   +14     
Impacted Files Coverage Δ
...sources/DSC_xDSCWebService/DSC_xDSCWebService.psm1 88% <ø> (ø)
...sources/DSC_xGroupResource/DSC_xGroupResource.psm1 70% <ø> (ø)
...sionConfiguration/DSC_xPSSessionConfiguration.psm1 0% <ø> (ø)
...ces/DSC_xPackageResource/DSC_xPackageResource.psm1 76% <ø> (-4%) ⬇️
...urces/DSC_xScriptResource/DSC_xScriptResource.psm1 100% <ø> (ø)
...ces/DSC_xServiceResource/DSC_xServiceResource.psm1 93% <ø> (ø)
...Resources/DSC_xUserResource/DSC_xUserResource.psm1 53% <ø> (ø)
...urces/DSC_xWindowsFeature/DSC_xWindowsFeature.psm1 86% <ø> (ø)
.../xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1 0% <ø> (ø)
...xEnvironmentResource/DSC_xEnvironmentResource.psm1 91% <100%> (ø)
... and 1 more

Copy link
Member Author

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 14 files reviewed, 3 unresolved discussions (waiting on @johlju)


.github/ISSUE_TEMPLATE/Problem_with_resource.yml, line 66 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
  - type: textarea
    id: exchangeVersion
    attributes:
      label: Exchange Server edition and version the target node is running
      description: |
        Please provide as much as possible about the Exchange Server that runs on the target node, for example edition, version, build, and language. _Will be automatically formatted as plain text._

        The following command can help get this information: `Get-ExchangeServer | ft ServerRole, Edition, AdminDisplayVersion`
      placeholder: |
        Add Exchange Server information here
      render: text
    validations:
      required: true

This can be removed.

Done.


RequiredModules.psd1, line 21 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
'DscResource.Common'        = 'latest'

If this is not necessary (not used by any resource) we should remove the copy part from build, or add it back here.

Copy/paste error - this file shouldn't have been changed. Have reverted.


RequiredModules.psd1, line 23 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
NetworkingDsc 

Just double checking, this module is no longer used by any examples and integration tests?

Copy/paste error - this file shouldn't have been changed. Have reverted.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju merged commit 19e10d1 into dsccommunity:main Oct 24, 2021
@johlju johlju removed the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Oct 24, 2021
@PlagueHO PlagueHO deleted the Issue-732 branch October 24, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI Pipeline Files from Latest Pattern
2 participants