-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pipeline files - Fixes #732 #733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @PlagueHO)
RequiredModules.psd1, line 21 at r1 (raw file):
'DscResource.Common' = 'latest'
If this is not necessary (not used by any resource) we should remove the copy part from build, or add it back here.
RequiredModules.psd1, line 23 at r1 (raw file):
NetworkingDsc
Just double checking, this module is no longer used by any examples and integration tests?
.github/ISSUE_TEMPLATE/Problem_with_resource.yml, line 66 at r1 (raw file):
Quoted 13 lines of code…
- type: textarea id: exchangeVersion attributes: label: Exchange Server edition and version the target node is running description: | Please provide as much as possible about the Exchange Server that runs on the target node, for example edition, version, build, and language. _Will be automatically formatted as plain text._ The following command can help get this information: `Get-ExchangeServer | ft ServerRole, Edition, AdminDisplayVersion` placeholder: | Add Exchange Server information here render: text validations: required: true
This can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 11 of 14 files reviewed, 3 unresolved discussions (waiting on @johlju)
.github/ISSUE_TEMPLATE/Problem_with_resource.yml, line 66 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
- type: textarea id: exchangeVersion attributes: label: Exchange Server edition and version the target node is running description: | Please provide as much as possible about the Exchange Server that runs on the target node, for example edition, version, build, and language. _Will be automatically formatted as plain text._ The following command can help get this information: `Get-ExchangeServer | ft ServerRole, Edition, AdminDisplayVersion` placeholder: | Add Exchange Server information here render: text validations: required: true
This can be removed.
Done.
RequiredModules.psd1, line 21 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
'DscResource.Common' = 'latest'
If this is not necessary (not used by any resource) we should remove the copy part from build, or add it back here.
Copy/paste error - this file shouldn't have been changed. Have reverted.
RequiredModules.psd1, line 23 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
NetworkingDsc
Just double checking, this module is no longer used by any examples and integration tests?
Copy/paste error - this file shouldn't have been changed. Have reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)
Pull Request (PR) description
This PR updates the pipeline files and the GitHub issue templates to the standards as per this PR against xExchange:
dsccommunity/ExchangeDsc#471
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
@johlju - would you mind reviewing when you have time?
This change is