Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repository to use the latest pipeline #471

Merged
merged 6 commits into from
Oct 10, 2021
Merged

Update repository to use the latest pipeline #471

merged 6 commits into from
Oct 10, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 30, 2021 •
edited
Loading

Pull Request (PR) description

  • xExchange
    • Update repository to use the latest pipeline (issue #466).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Sep 30, 2021
@johlju johlju marked this pull request as ready for review October 1, 2021 05:47
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Oct 1, 2021
@johlju
Copy link
Member Author

johlju commented Oct 1, 2021

@PlagueHO can you please review this one? It is a big one.

@johlju johlju requested a review from PlagueHO October 1, 2021 12:57
@codecov
Copy link

codecov bot commented Oct 3, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@9198ec7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             main   #471   +/-   ##
=====================================
  Coverage        ?    52%           
=====================================
  Files           ?     44           
  Lines           ?   5729           
  Branches        ?      0           
=====================================
  Hits            ?   2998           
  Misses          ?   2731           
  Partials        ?      0

@johlju johlju mentioned this pull request Oct 3, 2021
Merged
9 tasks
@PlagueHO
Copy link
Member

PlagueHO commented Oct 3, 2021

Will review tonight @johlju

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. needs review The pull request needs a code review. and removed needs review The pull request needs a code review. waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Oct 4, 2021
PlagueHO
PlagueHO reviewed Oct 4, 2021
View reviewed changes
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 24 files at r1.
Reviewable status: 3 of 24 files reviewed, all discussions resolved (waiting on @PlagueHO)

PlagueHO
PlagueHO reviewed Oct 4, 2021
View reviewed changes
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still working on the review @johlju - ran out of time last night

Reviewable status: 3 of 24 files reviewed, all discussions resolved (waiting on @PlagueHO)

@PlagueHO PlagueHO mentioned this pull request Oct 10, 2021
Closed
PlagueHO
PlagueHO requested changes Oct 10, 2021
View reviewed changes
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 24 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: 9 of 24 files reviewed, 1 unresolved discussion (waiting on @johlju and @PlagueHO)

CONTRIBUTING.md, line 7 at r3 (raw file):

## Running the Tests

If want to know how to run this module's tests you can look at the [Testing Guidelines](https://dsccommunity.org/guidelines/testing-guidelines/#running-tests)

Can you add full-stop at the end?

PlagueHO
PlagueHO reviewed Oct 10, 2021
View reviewed changes
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 24 files at r1, 1 of 2 files at r2.
Reviewable status: 18 of 24 files reviewed, 1 unresolved discussion (waiting on @johlju and @PlagueHO)

PlagueHO
PlagueHO reviewed Oct 10, 2021
View reviewed changes
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor tweak @johlju

Reviewed 6 of 24 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johlju)

@PlagueHO PlagueHO mentioned this pull request Oct 10, 2021
Merged
9 tasks
@johlju johlju requested a review from PlagueHO October 10, 2021 13:51
johlju
johlju commented Oct 10, 2021
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 23 of 24 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)

CONTRIBUTING.md, line 7 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you add full-stop at the end?

Done.

@johlju
Copy link
Member Author

johlju commented Oct 10, 2021

@PlagueHO ready for sign-off. 🙂

PlagueHO
PlagueHO approved these changes Oct 10, 2021
View reviewed changes
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

PlagueHO
PlagueHO approved these changes Oct 10, 2021
View reviewed changes
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 01f95e2 into dsccommunity:main Oct 10, 2021
@johlju johlju deleted the fix/pipeline-files branch October 10, 2021 19:36
This was referenced Apr 7, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlagueHO PlagueHO PlagueHO approved these changes

Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xExchange: Update the repository to use latest pipeline files
2 participants
@johlju @PlagueHO