Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of version 2.6.0.0 of xWebAdministration #421

Merged
merged 15 commits into from
May 15, 2019
Merged

Release of version 2.6.0.0 of xWebAdministration #421

merged 15 commits into from
May 15, 2019

Conversation

kwirkykat
Copy link
Contributor

@kwirkykat kwirkykat commented Apr 3, 2019

Releasing version 2.6.0.0


This change is Reviewable

@kwirkykat
Copy link
Contributor Author

@tysonjhayes @regedit32 @gaelcolas Release of this module is blocked by failing tests. Looks like PSSA errors. Let me know when it's fixed and then release can move forward.

@johlju
Copy link
Member

johlju commented Apr 16, 2019

@kwirkykat There is a reported bug in PSScriptAnalyzer for that PowerShell/PSScriptAnalyzer#1192. Once that is merged and a new release of PSScriptAnalyzer is made we can move forward with this. If we want to release this prior we should change the test framework to use an older version of PSScriptAnalyzer.

/cc @gaelcolas @PlagueHO @ykuijs

@ykuijs
Copy link
Member

ykuijs commented Apr 16, 2019

There is a workaround : move the super class to the top of the schema file. PSSA is only checking the first class in the schema.

@regedit32
Copy link
Member

I'll take this for action and apply the PSSA rule suppression until the fix to PSScriptAnalyzer is released

@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #421 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          17       17           
  Lines        2438     2438           
=======================================
  Hits         2213     2213           
  Misses        225      225
Impacted Files Coverage Δ
...SCResources/MSFT_xIisLogging/MSFT_xIisLogging.psm1 97.74% <100%> (ø) ⬆️
DSCResources/Helper.psm1 90% <100%> (ø) ⬆️
DSCResources/MSFT_xWebsite/MSFT_xWebsite.psm1 97.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9795b3a...3ed63bc. Read the comment docs.

@regedit32
Copy link
Member

fix merged to dev branch

@kwirkykat kwirkykat merged commit 91ef234 into master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants