Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #423 #424

Merged
merged 1 commit into from
May 14, 2019
Merged

fixes #423 #424

merged 1 commit into from
May 14, 2019

Conversation

regedit32
Copy link
Member

@regedit32 regedit32 commented May 14, 2019

Pull Request (PR) description

To work around the PSScriptAnalyzer introduced in 1.18 and described in #423 , this PR changes the order of the classes defined in schema.mof, for resources that had subclasses. The OMI_BaseResource class gets listed first now, which also happens to workaround the PSSA test that was erroneously failing.

This Pull Request (PR) fixes the following issues

#423

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #424 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #424   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          17       17           
  Lines        2438     2438           
=======================================
  Hits         2213     2213           
  Misses        225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1778f...4fb3c6a. Read the comment docs.

@regedit32 regedit32 merged commit fe3781e into dsccommunity:dev May 14, 2019
gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants