Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated disk example with size in bytes without measurement unit #218

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

fullenw1
Copy link
Contributor

@fullenw1 fullenw1 commented Nov 2, 2019

This Pull Request (PR) fixes the following issues

Fixes #214

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@fullenw1 fullenw1 mentioned this pull request Nov 2, 2019
9 tasks
@codecov-io
Copy link

codecov-io commented Nov 3, 2019

Codecov Report

Merging #218 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #218   +/-   ##
==================================
  Coverage   95%    95%           
==================================
  Files        7      7           
  Lines      985    985           
==================================
  Hits       943    943           
  Misses      42     42

@PlagueHO
Copy link
Member

Sorry about the delay @fullenw1 - we've been a bit focused on the migration process over to the DSC Community. I've updated the build so that we can get this through.

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @fullenw1)


CHANGELOG.md, line 9 at r2 (raw file):

## 4.9.0.0

- Disk:

Can you move this up to be in the ## Unreleased section and remove the duplicate ## 4.9.0.0 header?

Moved the change to the ## Unreleased section and removed the duplicate ## 4.9.0.0 header
@fullenw1
Copy link
Contributor Author

Can you move this up to be in the ## Unreleased section and remove the duplicate ## 4.9.0.0 header?

Done :)

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 4066517 into dsccommunity:dev Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants