-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated disk example with size in bytes without measurement unit #218
Conversation
Sorry about the delay @fullenw1 - we've been a bit focused on the migration process over to the DSC Community. I've updated the build so that we can get this through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @fullenw1)
CHANGELOG.md, line 9 at r2 (raw file):
## 4.9.0.0 - Disk:
Can you move this up to be in the ## Unreleased section and remove the duplicate ## 4.9.0.0 header?
Moved the change to the ## Unreleased section and removed the duplicate ## 4.9.0.0 header
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
This Pull Request (PR) fixes the following issues
Fixes #214
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is