Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk: Update Size value in example #214

Closed
wants to merge 2 commits into from

Conversation

fullenw1
Copy link
Contributor

@fullenw1 fullenw1 commented Oct 4, 2019

This Pull Request (PR) fixes the following issues

A value with a size unit (like MB or GB) does not work.
It generates the following error message:

Compilation errors occurred while processing configuration 'DscConfigurationName'. Please review the errors reported in error stream and modify your configuration code appropriately.

  • CategoryInfo : InvalidOperation: (DscConfiguration:String) [], InvalidOperationException
  • FullyQualifiedErrorId : FailToProcessConfiguration

Entering only a number works fine.

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

A value with a size unit (like MB or GB) does not work.
It generates the following error message:

Compilation errors occurred while processing configuration 'DscConfigurationName'. Please review the errors reported in error stream and modify your configuration code appropriately.
+ CategoryInfo : InvalidOperation: (DscConfiguration:String) [], InvalidOperationException
+ FullyQualifiedErrorId : FailToProcessConfiguration

Entering only a number works fine.
@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #214 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #214   +/-   ##
==================================
  Coverage   95%    95%           
==================================
  Files        7      7           
  Lines      980    980           
==================================
  Hits       939    939           
  Misses      41     41

@PlagueHO
Copy link
Member

PlagueHO commented Oct 4, 2019

Hi @fullenw1 - that is really strange. Using 10GB etc should work and passes the example compilation tests. See: https://ci.appveyor.com/project/PowerShell/StorageDsc/branch/dev?fullLog=true#L565

How are you compiling the examples?

@fullenw1
Copy link
Contributor Author

fullenw1 commented Oct 5, 2019

Hi @PlagueHO

How are you compiling the examples?

As I got the error message, I spotted by dichotomy the size parameter.
My intended value was different but I gave a try to 10GB like in the example (just copied/pasted the value) and got the same error.
When I used 10737418240 (the size in bytes), the error message disappeared.

By the way I got the exact same behavior on another resource:
dsccommunity/ComputerManagementDsc#278

@PlagueHO
Copy link
Member

PlagueHO commented Oct 5, 2019

I tried this as well yesterday and you're right - it is failing. Not sure how the Example tests are passing though. That is something I should look into. Anyway, let's proceed with this change.

Can you add an entry into the CHANGELOG.MD for this change?

@PlagueHO PlagueHO self-requested a review October 5, 2019 21:05
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Oct 5, 2019
@fullenw1
Copy link
Contributor Author

fullenw1 commented Oct 8, 2019

Can you add an entry into the CHANGELOG.MD for this change?

Done!
Please have a look. First time I do this on a DSC module...

@PlagueHO
Copy link
Member

Closing because superseded by #218

@PlagueHO PlagueHO closed this Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants